Homework 3 #3
Open
Homework 3 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forkosigan
suggested changes
Apr 4, 2021
| } | ||
|
|
||
| [HttpGet("from/{fromTime}/to/{toTime}/percentiles/{percentile}")] | ||
| public IActionResult GetMetricsByPercentileFromAgent([FromRoute] DateTime fromTime, [FromRoute] DateTime toTime, |
There was a problem hiding this comment.
ЗДесь тоже можно DateTimeOffset по идее
| foreach (var metric in metrics) | ||
| { | ||
| response.Metrics.Add(new CpuMetricDto | ||
| { Time = (DateTime)(UNIX.AddSeconds(metric.Time.TotalSeconds)), Value = metric.Value, Id = metric.Id }); |
There was a problem hiding this comment.
Стоит Time тоже сделать DateTimeOffset а преобразовывать через стандартные методы этого класса.
|
|
||
| namespace MetricsManager | ||
| { | ||
| public class WeatherForecast |
There was a problem hiding this comment.
Этому классу давно пора умереть. Наш проект развивается и убивание этого класса - часть рефакторинга
| public class CpuControllerUnitTests | ||
| { | ||
| private CpuMetricsController controller; | ||
| private Mock<IRepository<CpuMetric>> mock; |
| { | ||
| private CpuMetricsController controller; | ||
| private Mock<IRepository<CpuMetric>> mock; | ||
| private readonly ILogger<CpuMetricsController> _logger; |
There was a problem hiding this comment.
Не нашел, где инициализируется логгер. а ведь его тоже надо мОчить тут
| private Mock<IRepository<CpuMetric>> mock; | ||
| private readonly ILogger<CpuMetricsController> _logger; | ||
|
|
||
| public CpuControllerUnitTests() |
There was a problem hiding this comment.
Если контроллер называется CpuMetricsController, то тесты к нему принято называть CpuMetricsControllerTests. Разумеется если назвать их abcf все будет работать, но.... вобщем советую внимательно относится ко всем именования
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.