Homework 6 #6
Open
Homework 6 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add [FromQuery] and fix structure
Forkosigan
suggested changes
Apr 15, 2021
| { | ||
| using (var connection = new SQLiteConnection(ConnectionString)) | ||
| { | ||
| return connection.QuerySingle<CpuMetric>("SELECT * FROM cpumetrics ORDER BY id DESC LIMIT 1"); |
There was a problem hiding this comment.
На пустой базе запрос будет падать.
| { | ||
| using (var connection = new SQLiteConnection(ConnectionString)) | ||
| { | ||
| return connection.QuerySingle<CpuMetric>("SELECT * FROM cpumetrics ORDER BY id DESC LIMIT 1"); |
There was a problem hiding this comment.
На пустой базе запрос падает. Разумеется метрики не собираются
| public Task Execute(IJobExecutionContext context) | ||
| { | ||
| IList<AgentInfo> agents = _agentRepository.GetAll(); | ||
| var last = _UNIX.AddSeconds(_metricRepository.GetLast().Time.TotalSeconds); |
There was a problem hiding this comment.
опять эта ненужная константа _UNIX. Выпилить ее везде и переписать с использованием существующих методов Net Cor (DateTimeOffset.UnixEpoch)
|
|
||
| for (int i = 0; i < agents.Count; i++) | ||
| { | ||
| var temp = new GetAllCpuMetricsApiRequest(); |
There was a problem hiding this comment.
temp это что такое? температура? Я уже и на лекциях и в ревью много раз замечал что именования очень важны. Назовите нормально, пожалуйста, исходя из того что за сущность вы тут создаете
| public Task Execute(IJobExecutionContext context) | ||
| { | ||
| IList<AgentInfo> agents = _agentRepository.GetAll(); | ||
| var last = _UNIX.AddSeconds(_metricRepository.GetLast().Time.TotalSeconds); |
There was a problem hiding this comment.
это работать не будет. Last надо получать не вообще, а для каждого агента СВОЙ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.