Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views really should have unique ID's #13

Closed
GavinDBrown opened this issue Oct 18, 2014 · 5 comments
Closed

Views really should have unique ID's #13

GavinDBrown opened this issue Oct 18, 2014 · 5 comments

Comments

@GavinDBrown
Copy link
Contributor

When rotating the device, focus is lost because each EditText has the same ID.

In a view with 2 FloatLabel's and the second one focused, focus is granted to the first one on rotation.
IanGClifton added a commit that referenced this issue Oct 21, 2014
@IanGClifton
Fix for retaining focus, issue #13
947ccac 
This change saves the EditText's focus status in the saved state and restores it with the first measure.
@IanGClifton
Copy link
Owner

Fixed on master; I'll wait to close this out until after I have a chance to push to Maven Central. It will be in v1.0.2 and newer.

@GavinDBrown
Copy link
Contributor Author

Awesome! I was clearly thinking to do this with the framework by assigning unique ID's, but your way is much cleaner. Great library!

@lukaspili
Copy link

Do you have an ETA on pushing 1.0.2 to maven central ? Thanks

@IanGClifton
Copy link
Owner

Sorry for the delay. I've been out of state lately, but I'll be back this weekend and should push it Saturday or Sunday.

@IanGClifton
Copy link
Owner

1.0.2 is now in Maven Central

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukaspili @IanGClifton @GavinDBrown