Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes' clash #14

Closed
claudiopastorini opened this issue Oct 29, 2014 · 2 comments
Closed

Themes' clash #14

claudiopastorini opened this issue Oct 29, 2014 · 2 comments

Comments

@claudiopastorini
Copy link

Hi, the AndroidFloatLabel's theme clashes with my app's theme.

Error:(10, 9) Execution failed for task ':app:processDebugManifest'.
Manifest merger failed : Attribute application@theme value=(@style/MyAppTheme) from AndroidManifest.xml:10:9
is also present at com.iangclifton.android:floatlabel:1.0.1:15:9 value=(@style/AppTheme)
Suggestion: add 'tools:replace="android:theme"' to element at AndroidManifest.xml:6:5 to override

I resolved adding this in my gradle:

android {
useOldManifestMerger true
}

I think it is not an error, but it is my first time with this issue and I want to share my experience in order to help somebody with this beautiful library.

@IanGClifton
Copy link
Owner

Thanks for the info. I should probably rename the theme so it's namespaced and not generic; should be a quick fix, but I'd like to also test to make sure the UI falls back on the app's theme rather than the library's theme to support things like the AppCompat Material Design theme.

IanGClifton added a commit that referenced this issue Nov 5, 2014
This removes the reference to the AppTheme from the manifest to
eliminate issues with manifest mergers such as described in Issue #14.
@IanGClifton
Copy link
Owner

Fix is also in Maven Central as v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants