[docs] fetchMock -> fetchMocker #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reviewing code at work and I saw this:
```ts
beforeEach(() => {
const fetchMock = createFetchMock(vi);
fetchMock.enableMocks();
fetchMock.mockIf(`/bla`);
});
it("Bla", () => {
bla();
expect(fetchMock.mock.calls.length).toEqual(1);
});
```
I was confused, why we have `const fetchMock` in `beforeEach` but then reference `fetchMock` in the test, it should be undefined there, out of the scope.
Turns out it was because `fetchMock` is also a global variable.
Looking at type definitions, I see that `createFetchMock` is also called `createMocker`. So I think it'll make more sense to do this:
```ts
beforeEach(() => {
const fetchMocker = createFetchMock(vi);
fetchMocker.enableMocks();
fetchMocker.mockIf(`/bla`);
});
it("Bla", () => {
bla();
expect(fetchMock.mock.calls.length).toEqual(1);
});
```
This way there's no clash and it makes more sense - you create `fetchMocker`, then `fetchMocker.enableMocks()` will define global `fetchMock` for you.
Hope this makes sense!
Maxim-Mazurok
changed the title
IanVS
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing code at work and I saw this:
I was confused, why we have
const fetchMockinbeforeEachbut then referencefetchMockin the test, it should be undefined there, outside of the scope. Turns out it was becausefetchMockis also a global variable. Looking at type definitions, I see thatcreateFetchMockis also calledcreateMocker. So I think it'll make more sense to do this:This way there's no clash and it makes more sense - you create
fetchMocker, thenfetchMocker.enableMocks()will define globalfetchMockfor you. Hope this makes sense!