Ibis now builds under windows #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nist-anka
reviewed
Jul 31, 2018
| @@ -35,9 +33,7 @@ ExternalProject_Add( ${itk_name} | |||
| SOURCE_DIR ${external_project_dir}/${itk_name}/src | |||
| GIT_REPOSITORY "https://github.com/InsightSoftwareConsortium/ITK.git" | |||
| GIT_TAG v${IBIS_ITK_LONG_VERSION} | |||
There was a problem hiding this comment.
Is GIT_TAG defined twice?
nist-anka
reviewed
Jul 31, 2018
| static const double pi = 3.14159265358979323846; | ||
| static const double pi2 = 0.5 * IbisMath::pi; | ||
| static const double pi4 = 0.25 * IbisMath::pi; | ||
|
|
There was a problem hiding this comment.
Why not use Constants.h here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No hardware support and no non-default plugins have been compiled and tested yet.
Only tested build on Windows 10 so far.