Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting #455 changes, and Fixes for issues #515,#516,#517 #2

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

aozien
Copy link

@aozien aozien commented Jan 7, 2023

bldrs-ai#515:

  • Have a single SelectionChanged message instead of selection/deselection
  • The SelectionChanged message should be emitted regardless of the trigger

bldrs-ai#516:

  • Add a new ModelLoaded message that is emitted when the model has been loaded
  • From the automated tests, supply a local resource of an .ifc model instead of a network fetch to be independent of the network

bldrs-ai#517

  • make selection of elements in tests more reliable through the side menu

To be done

The tests in load-sample-model.cy.js are yet to be fixed, since FindByRole isn't reliable in the case of the "Open Ifc" button, and that's what's causing the tests to fail.

check for possible searchIndex bug for IFCProject global Id

@Ibrahim5aad Ibrahim5aad merged commit 616d4cf into Ibrahim5aad:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants