Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add chrome(ium) support to extension #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Aviana
Copy link

@Aviana Aviana commented Mar 29, 2024

This will add support for Chromium based browsers to the extension.

I have tested this on Firefox 124.0.1 and Chromium 123.0.6312.86.

While testing i encountered a Chromium (bug?) behavior that crashed the extension if chrome.runtime.sendNativeMessage was not awaited. This works fine on Firefox so i added the workaround that makes the popup menu take a second to load on Chromium. This shouldn't be a big deal.

The only needed change to package for chromium is to replace the manifest.json with the manifest-chrome.json and adjust the native extension once you get a release id on the chrome store.

Anyway, this is just for your consideration. Thanks for your work.

@alansartorio
Copy link
Collaborator

Thanks for looking into this.

I'll review and try it tomorrow.

I see that the install script wasn't modified, we'll have to take a look at how to install the native messaging hosts into all available browsers.

@Aviana
Copy link
Author

Aviana commented Mar 29, 2024

~/.config/chromium/NativeMessagingHosts/
etc/chromium/native-messaging-hosts/

~/.config/google-chrome/NativeMessagingHosts/
etc/opt/chrome/native-messaging-hosts/

~/.config/microsoft-edge/NativeMessagingHosts
etc/opt/edge/native-messaging-hosts/

~/.mozilla/native-messaging-hosts
usr/lib/mozilla/native-messaging-hosts/

Done.

@IceDBorn
Copy link
Owner

IceDBorn commented May 8, 2024

This is blocked because we need a Google dev account to obtain and use a unique extension key for native messaging hosts.

@IceDBorn IceDBorn added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2024
@Aviana
Copy link
Author

Aviana commented May 10, 2024

Oh man just saw that they require 5$ for setting up a dev account. Also they only accept credit cards. Desperate times at Google it seems.

Anyway if you need 5$ i can send it with paypal.

@IceDBorn
Copy link
Owner

My main problem is the way Google treats devs, not the price. Why don't you join the matrix server and discuss this further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants