New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MineOS to App Store #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigerinus
requested changes
May 9, 2023
Removed TZ env and changed category to 'Games'
@charagender - I tried to run your docker compose. It starts successfully. However I can't seem to get anything from the designated web ui URL. |
Moved `environment` comments from code to `casaosx` `envs` descriptions as requested per IceWhaleTech#42 (comment) and remapped WebUI host port from 8443 to 8443 as the latter port would not function properly (IceWhaleTech#42 (comment))
Updated `appfile.json` to match `docker-compose.yml`
tigerinus
requested changes
May 10, 2023
Changed default password to `root`, added before install tip to indicate default credentials, changed port from `8443:8444/tcp` to `8444:8443/tcp` (IceWhaleTech#42 (comment)) and added `scheme: https` (IceWhaleTech#42 (comment))
tigerinus
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MineOS is a tool for creating and managing minecraft servers. I created this from my own necessity.
This is the first time I do something like this, so it may have mistakes.
Created docker-compose.yml with mineos-node's docker-compose.yml as base