Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MineOS to App Store #42

Merged
merged 10 commits into from May 10, 2023
Merged

Add MineOS to App Store #42

merged 10 commits into from May 10, 2023

Conversation

charagender
Copy link
Contributor

@charagender charagender commented May 7, 2023

MineOS is a tool for creating and managing minecraft servers. I created this from my own necessity.
This is the first time I do something like this, so it may have mistakes.

Created docker-compose.yml with mineos-node's docker-compose.yml as base

Apps/MineOS/docker-compose.yml Outdated Show resolved Hide resolved
Apps/MineOS/docker-compose.yml Outdated Show resolved Hide resolved
Apps/MineOS/docker-compose.yml Outdated Show resolved Hide resolved
Removed TZ env and changed category to 'Games'
@tigerinus
Copy link
Contributor

tigerinus commented May 9, 2023

image

@charagender - I tried to run your docker compose. It starts successfully. However I can't seem to get anything from the designated web ui URL.

Moved `environment` comments from code to `casaosx` `envs` descriptions as requested per IceWhaleTech#42 (comment) and remapped WebUI host port from 8443 to 8443 as the latter port would not function properly (IceWhaleTech#42 (comment))
Updated `appfile.json` to match `docker-compose.yml`
Apps/MineOS/docker-compose.yml Outdated Show resolved Hide resolved
Apps/MineOS/docker-compose.yml Show resolved Hide resolved
Changed default password to `root`, added before install tip to indicate default credentials, changed port from `8443:8444/tcp` to `8444:8443/tcp` (IceWhaleTech#42 (comment)) and added `scheme: https` (IceWhaleTech#42 (comment))
Copy link
Contributor

@tigerinus tigerinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigerinus tigerinus merged commit 1988eae into IceWhaleTech:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants