Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] My CPU is a bit cold #661

Closed
Lars- opened this issue Nov 4, 2022 · 8 comments
Closed

[Bug] My CPU is a bit cold #661

Lars- opened this issue Nov 4, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Lars-
Copy link

Lars- commented Nov 4, 2022

Describe the bug
The temperature indicator in the system status widget reports -263200 degrees Celsius

To Reproduce
Steps to reproduce the behavior:

  1. Simply open CasaOS

Expected behavior
Report a normal temperature

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 107.0.5304.88

Additional context
I think I once saw it at a normal temperature, but I don't know why. It runs on an Intel NUC and it's the only application on the system.

@Lars- Lars- added the bug Something isn't working label Nov 4, 2022
@LinkLeong
Copy link
Collaborator

I'm sorry we don't offer a Win client, how do you run it in Win?

@Lars-
Copy link
Author

Lars- commented Nov 7, 2022

I don't run it on Windows. I open the browser on Windows. I run it on Debian 11.

@IceWhaleTech IceWhaleTech deleted a comment from raller1028 Nov 7, 2022
@LinkLeong
Copy link
Collaborator

Can you run "cat /sys/class/thermal/thermal_zone0/temp" and "cat /sys/class/hwmon/hwmon0/temp1_input" and give me the results?

@Lars-
Copy link
Author

Lars- commented Nov 7, 2022

image

@mojothemonkey2
Copy link
Contributor

mojothemonkey2 commented Nov 13, 2022

submitted a fix for this #677
my first "go" at golang ;), so please check for weirdness.

basically, the cpu temp is not always in thermal_zone 0.
so we need to find the right zone by the name in "type".
this can have many values, depending on platform. so search by list of strings, like others have done eg:
https://github.com/ThomasKaiser/sbc-bench/blob/master/sbc-bench.sh#L952

don't think we need to search hwmon too - they are created as part of thermal_zone registration, if I'm reading the doc right:
https://www.kernel.org/doc/html/latest/driver-api/thermal/sysfs-api.html

Test Evidence:

# /DATA/Documents/Code/CasaOS/dist/casaos-arm64_linux_arm64/build/sysroot/usr/bin/casaos -c /etc/casaos/casaos.conf
/bin/bash -c source ./shell/helper.sh ;GetDockerRootDir
{"level":"info","ts":1668340906.3049521,"msg":"CPU thermal zone found: soc_thermal, path: /sys/devices/virtual/thermal/thermal_zone0.","func":"service.GetCPUThermalZone","file":"/code/CasaOS/service/system.go","line":319}

@LinkLeong
Copy link
Collaborator

Thanks for the submission @mojothemonkey2 , I've merged it and will update it in a later release.

@LinkLeong LinkLeong reopened this Nov 16, 2022
@raller1028
Copy link
Contributor

@Lars- This problem has been fixed in v0.3.8, can you upgrade to v0.3.8 to verify if this problem has been fixed?

@Lars-
Copy link
Author

Lars- commented Nov 23, 2022

Done, it works now! Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants