-
Notifications
You must be signed in to change notification settings - Fork 27
[dev.icinga.com #1777] add highlight_table_rows to status.cgi #710
Comments
Updated by mjbrooks on 2011-08-03 08:44:24 +00:00
Thanks to Microsoft IE being non-standards compliant as well as existing table complications we'll revisit this for a future release. I definitely like polish like this though. |
Updated by mfriedrich on 2011-08-06 17:57:00 +00:00 the main problem is that the status table consists of sub tables, for each row and column, there's a sub table with a background colour and so on. so by just selecting a table row, this probably won't fit. |
Updated by mfriedrich on 2011-08-06 18:37:37 +00:00
|
Updated by mfriedrich on 2011-08-06 18:38:52 +00:00
|
Updated by mjbrooks on 2011-08-07 01:21:12 +00:00 Apparently you were more motivated for this than I thought. ;) I will check it out as soon as I can. |
Updated by mjbrooks on 2011-08-07 01:48:35 +00:00 I haven't looked at it you, but I saw the pics you posted on twitter. Would it be possible to have the highlight colors dependent on the status? They can be based on the unsaturated colors used in the TAC Header. I'm not sure having the status color completely obfuscated by the highlight is what we want. EDIT: I like where it's going though. ;) |
Updated by mfriedrich on 2011-08-07 10:58:58 +00:00 i'm not a designer - it was already hard finding a good grey instead of the blue. yes it will be possible. you might change the #defines and add the javascript string back to the code, leaving the color string out. then you'd check the current state of the service/host and assign the correct color code to it. but since i don't have any idea on how the overlay color should look i haven't made it that modular. |
Updated by ricardo on 2011-08-20 19:59:22 +00:00 Hi, can we please revert this change for 1.5 and add a reworked solution to 1.6. Think this isn't ready for production jet. |
Updated by mfriedrich on 2011-08-20 20:25:36 +00:00 change the defaults to disabled in the code and the cgi.cfg - i will use and need this in 1.5.0 |
Updated by mfriedrich on 2011-08-22 13:00:10 +00:00
experimental stays there, but yet disabled. if someone takes the hat for 1.6. rework, feel free. |
Updated by mfriedrich on 2011-09-12 13:37:01 +00:00
|
Updated by ricardo on 2011-09-28 18:58:59 +00:00
reworked this feature. used jquery, removed htables.js please test -> dev/cgis |
Updated by mfriedrich on 2011-09-30 21:33:10 +00:00 ok, thanks i will have look this weekend :) |
Updated by ricardo on 2011-10-06 21:08:44 +00:00 forget to change this in cgi.cfg.in. added in current rbaterls/cgi |
Updated by mfriedrich on 2011-10-20 11:23:42 +00:00 people upgrading won't see that either way, only fresh installs will get the fresh cgi.cfg - so users need to know about the CHANGE then. works fine at my stage, thanks. |
Updated by mfriedrich on 2011-11-11 17:01:25 +00:00
thanks again for implementing that properly, ricardo. |
Updated by mfriedrich on 2014-12-08 09:32:43 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/1777
Created by mfriedrich on 2011-08-03 08:27:38 +00:00
Assignee: ricardo
Status: Resolved (closed on 2011-11-11 17:01:25 +00:00)
Target Version: 1.6
Last Update: 2014-12-08 09:32:43 +00:00 (in Redmine)
basically to highlight the current service row, and to find the correct command tickbox on the right. sometimes it can be hard to figure that correctly, mostly on higher resolution and/or many services/hosts.
Changesets
2011-08-06 18:40:35 +00:00 by mfriedrich 9091cb0
2011-08-21 20:12:02 +00:00 by ricardo c13299e
2011-09-28 18:51:35 +00:00 by ricardo 420db34
2011-10-06 21:04:18 +00:00 by ricardo a493e09
Relations:
The text was updated successfully, but these errors were encountered: