[dev.icinga.com #1777] add highlight_table_rows to status.cgi #710

Closed
icinga-migration opened this Issue Aug 3, 2011 · 17 comments

Comments

Projects
None yet
1 participant
Member

icinga-migration commented Aug 3, 2011

This issue has been migrated from Redmine: https://dev.icinga.com/issues/1777

Created by mfriedrich on 2011-08-03 08:27:38 +00:00

Assignee: ricardo
Status: Resolved (closed on 2011-11-11 17:01:25 +00:00)
Target Version: 1.6
Last Update: 2014-12-08 09:32:43 +00:00 (in Redmine)


basically to highlight the current service row, and to find the correct command tickbox on the right. sometimes it can be hard to figure that correctly, mostly on higher resolution and/or many services/hosts.

[10:23:28]  my coworker just pointed me to that
[10:23:35]  when you have the status.cgi with many services
[10:23:40]  and you move your mouse over
[10:23:52]  over each line, nothing happens
[10:24:00]  so if there would be a "highlight"
[10:24:16]  one could recall the actual service text on the left, and tick the command box on the right
[10:24:24]  ah... you want a visual line tracking
[10:24:30]  sometimes you lose focus, and it's always hard to figure
[10:24:31]  yes
[10:24:42]  seen that in various guis
[10:24:47]  and i find it very useful
[10:24:51]  that would be a nice touch
[10:25:06]  ok
[10:25:11]  then i'll open a feature request
[10:25:34]  I believe that would be a CSS change and fairly straightforward
[10:25:57]  assuming the current CSS isn't spagghetti

Changesets

2011-08-06 18:40:35 +00:00 by mfriedrich 9091cb0

classic ui: add highlight_table_rows to status.cgi, can be disabled via cfg option #1777

uses a javascript library to highlight the complete row,
ignoring the nested tables where ids would fail on tr.

cgi.cfg option added to allow ppl to disable it on demand.

refs #1777

2011-08-21 20:12:02 +00:00 by ricardo c13299e

classic-ui: diabled highlight_table_rows by default.

refs: #1777

2011-09-28 18:51:35 +00:00 by ricardo 420db34

classic-ui: reworked highlight_table_rows and set to enabled by default #1777

refs: #1777

* now enabled by default
* removed htables.js
* substitued with a few lines jquery code in status.c

2011-10-06 21:04:18 +00:00 by ricardo a493e09

classic-ui: highlight_table_rows is now enabled by default in cgi.cfg #1777

refs: #1777

Relations:

Member

icinga-migration commented Aug 3, 2011

Updated by mjbrooks on 2011-08-03 08:44:24 +00:00

  • Priority changed from Normal to Low

Thanks to Microsoft IE being non-standards compliant as well as existing table complications we'll revisit this for a future release.

I definitely like polish like this though.

Member

icinga-migration commented Aug 6, 2011

Updated by mfriedrich on 2011-08-06 17:57:00 +00:00

the main problem is that the status table consists of sub tables, for each row and column, there's a sub table with a background colour and so on.

so by just selecting a table row, this probably won't fit.
http://www.permadi.com/tutorial/cssHighlightTableRow/index.html

Member

icinga-migration commented Aug 6, 2011

Updated by mfriedrich on 2011-08-06 18:37:37 +00:00

  • Subject changed from add visual line tracking to status.cgi to add highlight_table_rows to status.cgi, disabled via cfg option
  • Category set to 52
  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 1.5
Member

icinga-migration commented Aug 6, 2011

Updated by mfriedrich on 2011-08-06 18:38:52 +00:00

  • Subject changed from add highlight_table_rows to status.cgi, disabled via cfg option to add highlight_table_rows to status.cgi, can be disabled via cfg option
Member

icinga-migration commented Aug 7, 2011

Updated by mjbrooks on 2011-08-07 01:21:12 +00:00

Apparently you were more motivated for this than I thought. ;)

I will check it out as soon as I can.

Member

icinga-migration commented Aug 7, 2011

Updated by mjbrooks on 2011-08-07 01:48:35 +00:00

I haven't looked at it you, but I saw the pics you posted on twitter.

Would it be possible to have the highlight colors dependent on the status? They can be based on the unsaturated colors used in the TAC Header. I'm not sure having the status color completely obfuscated by the highlight is what we want.

EDIT: I like where it's going though. ;)

Member

icinga-migration commented Aug 7, 2011

Updated by mfriedrich on 2011-08-07 10:58:58 +00:00

i'm not a designer - it was already hard finding a good grey instead of the blue.

yes it will be possible. you might change the #defines and add the javascript string back to the code, leaving the color string out. then you'd check the current state of the service/host and assign the correct color code to it.

but since i don't have any idea on how the overlay color should look i haven't made it that modular.

Member

icinga-migration commented Aug 20, 2011

Updated by ricardo on 2011-08-20 19:59:22 +00:00

Hi,

can we please revert this change for 1.5 and add a reworked solution to 1.6.

Think this isn't ready for production jet.

Member

icinga-migration commented Aug 20, 2011

Updated by mfriedrich on 2011-08-20 20:25:36 +00:00

change the defaults to disabled in the code and the cgi.cfg - i will use and need this in 1.5.0

Member

icinga-migration commented Aug 22, 2011

Updated by mfriedrich on 2011-08-22 13:00:10 +00:00

  • Status changed from Assigned to Feedback
  • Assigned to deleted mfriedrich
  • Target Version changed from 1.5 to 1.6
  • Done % changed from 0 to 50

experimental stays there, but yet disabled. if someone takes the hat for 1.6. rework, feel free.

Member

icinga-migration commented Sep 12, 2011

Updated by mfriedrich on 2011-09-12 13:37:01 +00:00

  • Subject changed from add highlight_table_rows to status.cgi, can be disabled via cfg option to add highlight_table_rows to status.cgi
  • Assigned to set to ricardo
Member

icinga-migration commented Sep 28, 2011

Updated by ricardo on 2011-09-28 18:58:59 +00:00

  • Done % changed from 50 to 100

reworked this feature.

used jquery, removed htables.js

please test -> dev/cgis

Member

icinga-migration commented Sep 30, 2011

Updated by mfriedrich on 2011-09-30 21:33:10 +00:00

ok, thanks i will have look this weekend :)

Member

icinga-migration commented Oct 6, 2011

Updated by ricardo on 2011-10-06 21:08:44 +00:00

forget to change this in cgi.cfg.in. added in current rbaterls/cgi

Member

icinga-migration commented Oct 20, 2011

Updated by mfriedrich on 2011-10-20 11:23:42 +00:00

people upgrading won't see that either way, only fresh installs will get the fresh cgi.cfg - so users need to know about the CHANGE then.

works fine at my stage, thanks.

Member

icinga-migration commented Nov 11, 2011

Updated by mfriedrich on 2011-11-11 17:01:25 +00:00

  • Status changed from Feedback to Resolved

thanks again for implementing that properly, ricardo.

Member

icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:32:43 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 52 to Classic UI

icinga-migration added this to the 1.6 milestone Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment