Skip to content
This repository has been archived by the owner. It is now read-only.

[dev.icinga.com #2117] reset forms on return after submitting command #795

Closed
icinga-migration opened this issue Nov 24, 2011 · 9 comments
Labels
Milestone

Comments

@icinga-migration
Copy link
Member

@icinga-migration icinga-migration commented Nov 24, 2011

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2117

Created by mzac on 2011-11-24 14:30:33 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-04-13 19:04:18 +00:00)
Target Version: 1.7
Last Update: 2014-12-08 09:42:24 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

When you use the check boxes next to hosts or services and then choose for example 'acknowledge' in the 'Select command' drop box, then choose your acknowledge and then done you come back to the same screen, however the same hosts/services are still checked and the 'Select command' drop box stays in the same place and the 'Submit' button is greyed out.

This page should be refreshed when clicking on the 'Done' button.

Changesets

2012-03-07 22:33:52 +00:00 by ricardo 90ee3e4

classic ui: fixed reset forms on return after submitting command #2117

refs: #2117

* forms getting reset on page load
* fixed problem with downtime checkbox selection
* changed all forms to POST request
* removed unused / cleaned up - javascript code

2012-04-13 18:48:07 +00:00 by ricardo 7b9ec5b

classic-ui: updated Changelog CHANGES section

refs: #1524
refs: #1981
refs: #2018
refs: #2117
refs: #2119
refs: #2145
refs: #2198
refs: #2343
refs: #2359
refs: #2373
refs: #2421

hope the "changes" section for classic ui isn't tooo long

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Nov 24, 2011

Updated by mzac on 2011-11-24 15:52:17 +00:00

This seems to be happening with Chrome but not with IE

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 16, 2011

Updated by ricardo on 2011-12-16 22:33:05 +00:00

Hi,

Yeah this seems to be an webkit issue.

Unfortunately I have no Idea how to resolve that.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Jan 24, 2012

Updated by ricardo on 2012-01-24 23:19:12 +00:00

could be done with a

i guess. Don't know if it would work, but worth a try.

can you add this to the body tag in cgiutils.cgi document_header

onload="checked=true; checkAll('tableformservice');"

to see if it works for service status list?

thanks

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Mar 7, 2012

Updated by ricardo on 2012-03-07 22:39:16 +00:00

  • Subject changed from Sticky dropdown 'Select command' to reset forms on return after submitting command
  • Status changed from New to Feedback
  • Assigned to set to ricardo
  • Target Version set to 1.7

Hi,

I think I got the problem fixed. The forms now getting reset after page is loaded.

Worked in all my test. Please test it your self as well.

in current 'rbartels/cgi'

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 3, 2012

Updated by mfriedrich on 2012-04-03 13:39:00 +00:00

the problem is now that this works like a charm on sending a command and then coming back to the status.cgi listing.

but the changed reload with javascript now generates an effect that the tickboxes and command selection is cleared as well. i would expect that to be "reload safe" instead.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 3, 2012

Updated by mfriedrich on 2012-04-03 13:39:46 +00:00

~/coding/icinga/icinga-core $ git log -5
commit 7e7f5d85789c22fbe3b7c60c1c8b4bf33bf4663e
Author: Michael Friedrich 
Date:   Tue Apr 3 10:48:05 2012 +0200

    final fix compatibility problems on solaris 10 (Carl R. Friend) #2292

    refs #2292

commit d8bd0c18b973428e20ec2040b7e9f24445283468
Merge: 6e8181f 64b5e9c
Author: Ricardo Bartels 
Date:   Mon Mar 19 23:11:15 2012 +0100

    Merge branch 'rbartels/cgi' into dev/cgis

commit 64b5e9cfe7706d1ff7040c5ee28076c13ab7b7bb
Author: Ricardo Bartels 
Date:   Mon Mar 19 23:02:06 2012 +0100

    classic-ui: change javascript page refresh method again.

    hope this works persintent in all browser implementations now.
    damn IE

commit 398d62fa27e7b0417a0f2b76caf1c98b49ec0cd5
Author: Ricardo Bartels 
Date:   Sun Mar 18 11:34:25 2012 +0100

    classic-ui: change javascript page refresh method again.

    hope this works persintent in all browser implementations now.
    damn IE

commit 8f37d9c3321ceabe5073c342322c94656cdb9a92
Author: Ricardo Bartels 
Date:   Sun Mar 18 09:50:57 2012 +0100

    classic-ui: ost/service healt in rac.cgi now clickable
@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 13, 2012

Updated by ricardo on 2012-04-13 15:11:43 +00:00

When you check or select something in the status list, the refresh counter will be reset to default and starts counting down again.

It won't be reload safe. We can't distinct if it's a reload or you coming back from sending a command.

shloud be ready to go now.

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Apr 13, 2012

Updated by ricardo on 2012-04-13 19:04:18 +00:00

  • Status changed from Feedback to Resolved

Added note to changes in Changelog

@icinga-migration

This comment has been minimized.

Copy link
Member Author

@icinga-migration icinga-migration commented Dec 8, 2014

Updated by mfriedrich on 2014-12-08 09:42:24 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category changed from 52 to Classic UI
  • Icinga Version set to 1
  • OS Version set to any
@icinga-migration icinga-migration added this to the 1.7 milestone Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.