Skip to content

Commit

Permalink
Send notifications for non-state events as well
Browse files Browse the repository at this point in the history
  • Loading branch information
yhabteab committed Apr 22, 2024
1 parent a9070b6 commit 0419c32
Showing 1 changed file with 8 additions and 16 deletions.
24 changes: 8 additions & 16 deletions internal/incident/incident.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,23 +147,15 @@ func (i *Incident) ProcessEvent(ctx context.Context, ev *event.Event) error {
return errors.New("can't insert incident event to the database")
}

if ev.Type == event.TypeAcknowledgementSet || ev.Type == event.TypeAcknowledgementCleared {
if err = i.processAcknowledgementEvent(ctx, tx, ev); err != nil {
return err
}

if err = tx.Commit(); err != nil {
i.logger.Errorw("Can't commit db transaction", zap.Error(err))

return errors.New("can't commit db transaction")
switch ev.Type {
case event.TypeState:
if !isNew {
if err := i.processSeverityChangedEvent(ctx, tx, ev); err != nil {
return err
}
}

return nil
}

if !isNew {
err := i.processSeverityChangedEvent(ctx, tx, ev)
if err != nil {
case event.TypeAcknowledgementSet, event.TypeAcknowledgementCleared:
if err := i.processAcknowledgementEvent(ctx, tx, ev); err != nil {
return err
}
}
Expand Down

0 comments on commit 0419c32

Please sign in to comment.