Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename icinga-notifications-daemon -> icinga-notifications #169

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

yhabteab
Copy link
Member

It's pointless to append -daemon to the product name, and we don't do it that way in Icinga DB btw.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Apr 10, 2024
@julianbrost
Copy link
Collaborator

I wouldn't say it's completely pointless. With Icinga DB, the thing is, if you say just that, it's not clear if you referring to its Go daemon in particular or the whole thing, i.e. including Icinga DB Web and the Icinga 2 feature. So keeping the daemon suffix would give it a distinct name. But yes, that would be inconsistent with Icinga DB, so I won't insist on this, but I'd like to hear a few more opinions before deciding.

@oxzi
Copy link
Member

oxzi commented Apr 18, 2024

While I support @julianbrost's call to reduce naming ambiguity, I think @yhabteab has a valid point, especially since the current executable name is unnecessarily long. Maybe add a d, icinga-notificationsd, unless we want to honor 8.3 filenames.

Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there were no name suggestions that were so convincing that it would justify inconsistent naming with other Icinga projects, we'll do it as suggested by this PR. It just got conflicts in the meantime and thus needs a rebase.

@julianbrost julianbrost merged commit bd9633f into main Jun 18, 2024
12 checks passed
@julianbrost julianbrost deleted the rename-executable branch June 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants