Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Get-IcingaClusterSharedVolumeData.psm1 #50

Merged
merged 2 commits into from Aug 1, 2023

Conversation

PatrickHees
Copy link
Contributor

This pull request resolves the dependency between clustered shared volume and shared disk in the "Invoke-IcingaCheckClusterSharedVolume" check.

The following constellations were then tested with the adjustment:

Clustered Shared Volumes and Shared Disk
Both are properly monitored

Clustered shared volumes only
Only the clustered shared volumes are monitored.

Shared disk only
Only the shared disks contained in the cluster are monitored.

Neither Cluster Shared Volumes nor Shared Disk
The check has the status "unknown" in Icinga because neither cluster shared volumes nor shared disks were found.

This pull request corresponds to support case #784384.

Resolving the dependency between Clustered Shared Volume and Clustered Disk
@cla-bot
Copy link

cla-bot bot commented Jul 12, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @PatrickHees

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jul 12, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @PatrickHees

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Jul 12, 2023
@PatrickHees
Copy link
Contributor Author

CLA was signed by me.

@LordHepipud LordHepipud merged commit f6715a4 into Icinga:master Aug 1, 2023
1 check passed
@LordHepipud
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants