Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disk health error for int to str enum conversion #345

Merged

Conversation

LordHepipud
Copy link
Collaborator

@LordHepipud LordHepipud commented May 8, 2023

Fixes an issue for disk health plugin, which can fail in some cases due to an invalid conversion from the MSFT output from int to string.

Fixes #342
Fixes #337

@cla-bot cla-bot bot added the cla/signed label May 8, 2023
@LordHepipud LordHepipud added the bug Something isn't working label May 8, 2023
@LordHepipud LordHepipud self-assigned this May 8, 2023
@LordHepipud LordHepipud added this to the v1.11.0 milestone May 8, 2023
@K0nne
Copy link
Contributor

K0nne commented May 8, 2023

The PR works like a charm.

@K0nne
Copy link
Contributor

K0nne commented May 8, 2023

This issue could also be affected: #337

@LordHepipud
Copy link
Collaborator Author

Thanks for the quick feedback!

@LordHepipud LordHepipud merged commit bb77d0e into master May 8, 2023
1 check passed
@LordHepipud LordHepipud deleted the fix/diskhealth_error_for_int_to_string_enum_conversion branch May 8, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
2 participants