Fix pending state handling in ColumnRenderer for IcingaStatus (refs #…

…3843) the problem was caused by an string to int comparsion using ===
Icinga · Mar 17, 2013 · 78b36c3 · 78b36c3
1 parent a49f9d4
commit 78b36c3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/modules/Cronks/lib/js/Cronk/grid/renderer/AdvancedHostStatusColumnRenderer.js b/app/modules/Cronks/lib/js/Cronk/grid/renderer/AdvancedHostStatusColumnRenderer.js
@@ -138,7 +138,7 @@ Ext.ns('Cronk.grid');
         this.hostStatus = function () {
             return function (value, metaData, record, rowIndex, colIndex, store) {
                 if (Ext.isDefined(record.json.host_has_been_checked)) {
-                    if (record.json.host_has_been_checked === 0) {
+                    if (record.json.host_has_been_checked == 0) {
                         value = 99;
                     }
                 }

diff --git a/app/modules/Cronks/lib/js/Cronk/grid/renderer/ColumnRenderer.js b/app/modules/Cronks/lib/js/Cronk/grid/renderer/ColumnRenderer.js
@@ -252,11 +252,11 @@ Ext.ns('Cronk.grid');
                 return function (value, metaData, record, rowIndex, colIndex, store) {
 
                     if (Ext.isDefined(record.json.service_is_pending)) {
-                        if (record.json.service_is_pending > 0) {
+                        if (record.json.service_is_pending == 1) {
                             value = 99;
                         }
                     } else if (Ext.isDefined(record.json.service_has_been_checked)) {
-                        if (record.json.service_has_been_checked === 0) {
+                        if (record.json.service_has_been_checked == 0) {
                             value = 99;
                         }
                     }
@@ -270,11 +270,11 @@ Ext.ns('Cronk.grid');
             hostStatus: function (cfg) {
                 return function (value, metaData, record, rowIndex, colIndex, store) {
                     if (Ext.isDefined(record.json.host_is_pending)) {
-                        if (record.json.host_is_pending > 0) {
+                        if (record.json.host_is_pending == 1) {
                             value = 99;
                         }
                     } else if (Ext.isDefined(record.json.host_has_been_checked)) {
-                        if (record.json.host_has_been_checked === 0) {
+                        if (record.json.host_has_been_checked == 0) {
                             value = 99;
                         }
                     }
@@ -312,4 +312,4 @@ Ext.ns('Cronk.grid');
             }
     };
 
-})();
+})();