Revert "LongPluginOutput: Fix missing support of multi line in html"

This reverts commit 14fdf63.

The fix actually fixes nothing for the following reasons:

1) The "Long plugin output" field of a host's or service's detail window already has `\n' replaced with the HTML break tag.
This is because the information is gathered via Icinga Web's API which calls `Api_Result_OutputRewriteModel::rewritePluginOutput()'
in the controller `ApiSearchAction'.
Note that the carriage return `\r' is not taken into accout, but that's not a problem here.

2) Grids do not benefit from `Api_Result_OutputRewriteModel::rewritePluginOutput()' as its not being called. The `nl2br()' should've
helped here. According to http://www.ietf.org/rfc/rfc4627.txt the JSON representation of strings must escape control characters which includes the line feed `\n'
and the carriage return `\r'. So '\n', '\r' and '\r\n' become '\\n', '\\r' and '\\r\\n' respectively making them a textual representation of the control characters.
The `nl2br()' implementation however only replaces the unescaped line feed and carriage return which does of course replace nothing in the above case.

3) Introducing `String::nl2br()' while ExtJS provides `Ext.util.Format.nl2br()' is superfluous.

refs #2653

app/modules/AppKit/config/javascript.xml

@@ -59,7 +59,6 @@
             <ae:parameter>%core.root_dir%/lib/jsgettext/lib/Gettext.js</ae:parameter>
 
             <ae:parameter>%core.module_dir%/AppKit/lib/js/ext-overrides/TreeNodeDontLeak.js</ae:parameter>
-            <ae:parameter>%core.module_dir%/AppKit/lib/js/utils/String.js</ae:parameter>
         </javascript>
 
 <!--

app/modules/Cronks/lib/js/Cronk/grid/renderer/ColumnRenderer.js

@@ -80,13 +80,6 @@ Ext.ns('Cronk.grid');
     Cronk.grid.ColumnRenderer = {
 
         customColumnPerfdataSanitized: function (cfg) {
-
-            var multiLine = false;
-
-            if (!Ext.isEmpty(cfg.multiLine) && cfg.multiLine) {
-                multiLine = true;
-            }
-
             return function (value, metaData, record, rowIndex, colIndex, store) {
                 if (!value) {
                     return _('no value');
@@ -106,10 +99,6 @@ Ext.ns('Cronk.grid');
 
                 metaData.attr = 'ext:qtip="' + Ext.util.Format.htmlEncode(value) + '"';
 
-                if (multiLine === true) {
-                    value = String(value).nl2br();
-                }
-
                 return value;
             };
         },

app/modules/Cronks/lib/js/Icinga/Cronks/Tackle/Information/LongPluginOutput.js

@@ -29,7 +29,6 @@ Ext.ns('Icinga.Cronks.Tackle.Information');
     Icinga.Cronks.Tackle.Information.LongPluginOutput = Ext.extend(
         Icinga.Cronks.Tackle.Information.OutputPanel, {
         title: _("Long plugin output"),
-        keepLineBreaksInHTML: true,
         tplField: 'object_long_output'
     });
 

app/modules/Cronks/lib/js/Icinga/Cronks/Tackle/Information/OutputPanel.js

@@ -28,7 +28,6 @@ Ext.ns('Icinga.Cronks.Tackle.Information');
 
     Icinga.Cronks.Tackle.Information.OutputPanel = Ext.extend(Ext.Panel, {
         autoScroll: true,
-        keepLineBreaksInHTML: false,
 
         constructor: function(c) {
             Icinga.Cronks.Tackle.Information
@@ -49,17 +48,6 @@ Ext.ns('Icinga.Cronks.Tackle.Information');
 
             Icinga.Cronks.Tackle.Information
                 .OutputPanel.superclass.initComponent.call(this);
-        },
-
-        update: function(htmlOrData, loadScripts, cb) {
-            if (!Ext.isEmpty(this.tplField) && this.keepLineBreaksInHTML === true) {
-                if (!Ext.isEmpty(htmlOrData[this.tplField])) {
-                    htmlOrData[this.tplField] = String(htmlOrData[this.tplField]).nl2br();
-                }
-            }
-
-            Icinga.Cronks.Tackle.Information
-                .OutputPanel.superclass.update.call(this, htmlOrData, loadScripts, cb);
         }
     });