Skip to content

Commit

Permalink
Rename macro RequireNotNull to REQUIRE_NOT_NULL
Browse files Browse the repository at this point in the history
  • Loading branch information
Crunsher committed Feb 21, 2018
1 parent 7aa5e54 commit 7b1d9ed
Show file tree
Hide file tree
Showing 23 changed files with 61 additions and 61 deletions.
34 changes: 17 additions & 17 deletions lib/base/array-script.cpp
Expand Up @@ -30,55 +30,55 @@ static double ArrayLen()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->GetLength();
}

static void ArraySet(int index, const Value& value)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Set(index, value);
}

static Value ArrayGet(int index)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Get(index);
}

static void ArrayAdd(const Value& value)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Add(value);
}

static void ArrayRemove(int index)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Remove(index);
}

static bool ArrayContains(const Value& value)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Contains(value);
}

static void ArrayClear()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Clear();
}

Expand All @@ -91,7 +91,7 @@ static Array::Ptr ArraySort(const std::vector<Value>& args)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

Array::Ptr arr = self->ShallowClone();

Expand All @@ -115,15 +115,15 @@ static Array::Ptr ArrayShallowClone()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->ShallowClone();
}

static Value ArrayJoin(const Value& separator)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

Value result;
bool first = true;
Expand All @@ -146,15 +146,15 @@ static Array::Ptr ArrayReverse()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Reverse();
}

static Array::Ptr ArrayMap(const Function::Ptr& function)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

if (vframe->Sandboxed && !function->IsSideEffectFree())
BOOST_THROW_EXCEPTION(ScriptError("Map function must be side-effect free."));
Expand All @@ -173,7 +173,7 @@ static Value ArrayReduce(const Function::Ptr& function)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

if (vframe->Sandboxed && !function->IsSideEffectFree())
BOOST_THROW_EXCEPTION(ScriptError("Reduce function must be side-effect free."));
Expand All @@ -195,7 +195,7 @@ static Array::Ptr ArrayFilter(const Function::Ptr& function)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

if (vframe->Sandboxed && !function->IsSideEffectFree())
BOOST_THROW_EXCEPTION(ScriptError("Filter function must be side-effect free."));
Expand All @@ -215,7 +215,7 @@ static bool ArrayAny(const Function::Ptr& function)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

if (vframe->Sandboxed && !function->IsSideEffectFree())
BOOST_THROW_EXCEPTION(ScriptError("Filter function must be side-effect free."));
Expand All @@ -233,7 +233,7 @@ static bool ArrayAll(const Function::Ptr& function)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

if (vframe->Sandboxed && !function->IsSideEffectFree())
BOOST_THROW_EXCEPTION(ScriptError("Filter function must be side-effect free."));
Expand All @@ -250,7 +250,7 @@ static Array::Ptr ArrayUnique()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Array::Ptr self = static_cast<Array::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

std::set<Value> result;

Expand Down
4 changes: 2 additions & 2 deletions lib/base/configobject-script.cpp
Expand Up @@ -29,15 +29,15 @@ static void ConfigObjectModifyAttribute(const String& attr, const Value& value)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
ConfigObject::Ptr self = vframe->Self;
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->ModifyAttribute(attr, value);
}

static void ConfigObjectRestoreAttribute(const String& attr)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
ConfigObject::Ptr self = vframe->Self;
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->RestoreAttribute(attr);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/base/datetime-script.cpp
Expand Up @@ -29,7 +29,7 @@ static String DateTimeFormat(const String& format)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
DateTime::Ptr self = static_cast<DateTime::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

return self->Format(format);
}
Expand Down
16 changes: 8 additions & 8 deletions lib/base/dictionary-script.cpp
Expand Up @@ -29,55 +29,55 @@ static double DictionaryLen()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->GetLength();
}

static void DictionarySet(const String& key, const Value& value)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Set(key, value);
}

static Value DictionaryGet(const String& key)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Get(key);
}

static void DictionaryRemove(const String& key)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->Remove(key);
}

static bool DictionaryContains(const String& key)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Contains(key);
}

static Dictionary::Ptr DictionaryShallowClone()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->ShallowClone();
}

static Array::Ptr DictionaryKeys()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

ArrayData keys;
ObjectLock olock(self);
Expand All @@ -91,7 +91,7 @@ static Array::Ptr DictionaryValues()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Dictionary::Ptr self = static_cast<Dictionary::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

ArrayData values;
ObjectLock olock(self);
Expand Down
4 changes: 2 additions & 2 deletions lib/base/function-script.cpp
Expand Up @@ -32,7 +32,7 @@ static Value FunctionCall(const std::vector<Value>& args)

ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Function::Ptr self = static_cast<Function::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

std::vector<Value> uargs(args.begin() + 1, args.end());
return self->InvokeThis(args[0], uargs);
Expand All @@ -42,7 +42,7 @@ static Value FunctionCallV(const Value& thisArg, const Array::Ptr& args)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Function::Ptr self = static_cast<Function::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

std::vector<Value> uargs;

Expand Down
6 changes: 3 additions & 3 deletions lib/base/object-script.cpp
Expand Up @@ -29,23 +29,23 @@ static String ObjectToString()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Object::Ptr self = static_cast<Object::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->ToString();
}

static void ObjectNotifyAttribute(const String& attribute)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Object::Ptr self = static_cast<Object::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->NotifyField(self->GetReflectionType()->GetFieldId(attribute));
}

static Object::Ptr ObjectClone()
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Object::Ptr self = static_cast<Object::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
return self->Clone();
}

Expand Down
2 changes: 1 addition & 1 deletion lib/base/object.cpp
Expand Up @@ -295,4 +295,4 @@ void icinga::RequireNotNullInternal(const intrusive_ptr<Object>& object, const c
{
if (!object)
BOOST_THROW_EXCEPTION(std::invalid_argument("Pointer must not be null: " + String(description)));
}
}
2 changes: 1 addition & 1 deletion lib/base/object.hpp
Expand Up @@ -57,7 +57,7 @@ extern Value Empty;
DECLARE_PTR_TYPEDEFS(klass); \
IMPL_TYPE_LOOKUP();

#define RequireNotNull(ptr) RequireNotNullInternal(ptr, #ptr)
#define REQUIRE_NOT_NULL(ptr) RequireNotNullInternal(ptr, #ptr)

void RequireNotNullInternal(const intrusive_ptr<Object>& object, const char *description);

Expand Down
2 changes: 1 addition & 1 deletion lib/base/typetype-script.cpp
Expand Up @@ -35,7 +35,7 @@ static void TypeRegisterAttributeHandler(const String& fieldName, const Function
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Type::Ptr self = static_cast<Type::Ptr>(vframe->Self);
RequireNotNull(self);
REQUIRE_NOT_NULL(self);

int fid = self->GetFieldId(fieldName);
self->RegisterAttributeHandler(fid, std::bind(&InvokeAttributeHandlerHelper, callback, _1, _2));
Expand Down
2 changes: 1 addition & 1 deletion lib/icinga/checkable-script.cpp
Expand Up @@ -30,7 +30,7 @@ static void CheckableProcessCheckResult(const CheckResult::Ptr& cr)
{
ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
Checkable::Ptr self = vframe->Self;
RequireNotNull(self);
REQUIRE_NOT_NULL(self);
self->ProcessCheckResult(cr);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/icinga/macroprocessor.cpp
Expand Up @@ -38,7 +38,7 @@ Value MacroProcessor::ResolveMacros(const Value& str, const ResolverList& resolv
bool useResolvedMacros, int recursionLevel)
{
if (useResolvedMacros)
RequireNotNull(resolvedMacros);
REQUIRE_NOT_NULL(resolvedMacros);

Value result;

Expand Down Expand Up @@ -440,7 +440,7 @@ Value MacroProcessor::ResolveArguments(const Value& command, const Dictionary::P
const Dictionary::Ptr& resolvedMacros, bool useResolvedMacros, int recursionLevel)
{
if (useResolvedMacros)
RequireNotNull(resolvedMacros);
REQUIRE_NOT_NULL(resolvedMacros);

Value resolvedCommand;
if (!arguments || command.IsObjectType<Array>() || command.IsObjectType<Function>())
Expand Down
4 changes: 2 additions & 2 deletions lib/methods/clusterchecktask.cpp
Expand Up @@ -38,8 +38,8 @@ REGISTER_SCRIPTFUNCTION_NS(Internal, ClusterCheck, &ClusterCheckTask::ScriptFunc
void ClusterCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr,
const Dictionary::Ptr& resolvedMacros, bool useResolvedMacros)
{
RequireNotNull(checkable);
RequireNotNull(cr);
REQUIRE_NOT_NULL(checkable);
REQUIRE_NOT_NULL(cr);

if (resolvedMacros && !useResolvedMacros)
return;
Expand Down
4 changes: 2 additions & 2 deletions lib/methods/clusterzonechecktask.cpp
Expand Up @@ -34,8 +34,8 @@ REGISTER_SCRIPTFUNCTION_NS(Internal, ClusterZoneCheck, &ClusterZoneCheckTask::Sc
void ClusterZoneCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr,
const Dictionary::Ptr& resolvedMacros, bool useResolvedMacros)
{
RequireNotNull(checkable);
RequireNotNull(cr);
REQUIRE_NOT_NULL(checkable);
REQUIRE_NOT_NULL(cr);

ApiListener::Ptr listener = ApiListener::GetInstance();

Expand Down
4 changes: 2 additions & 2 deletions lib/methods/dummychecktask.cpp
Expand Up @@ -36,8 +36,8 @@ REGISTER_SCRIPTFUNCTION_NS(Internal, DummyCheck, &DummyCheckTask::ScriptFunc, "c
void DummyCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr,
const Dictionary::Ptr& resolvedMacros, bool useResolvedMacros)
{
RequireNotNull(checkable);
RequireNotNull(cr);
REQUIRE_NOT_NULL(checkable);
REQUIRE_NOT_NULL(cr);

CheckCommand::Ptr commandObj = checkable->GetCheckCommand();

Expand Down
4 changes: 2 additions & 2 deletions lib/methods/exceptionchecktask.cpp
Expand Up @@ -34,8 +34,8 @@ REGISTER_SCRIPTFUNCTION_NS(Internal, ExceptionCheck, &ExceptionCheckTask::Script
void ExceptionCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckResult::Ptr& cr,
const Dictionary::Ptr& resolvedMacros, bool useResolvedMacros)
{
RequireNotNull(checkable);
RequireNotNull(cr);
REQUIRE_NOT_NULL(checkable);
REQUIRE_NOT_NULL(cr);

if (resolvedMacros && !useResolvedMacros)
return;
Expand Down

0 comments on commit 7b1d9ed

Please sign in to comment.