DB IDO: Send endpoint authority for status updates.

Refs #5636
Icinga · Mar 10, 2014 · ac24d15 · ac24d15
1 parent 843af71
commit ac24d15
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 10 deletions.
diff --git a/components/db_ido_pgsql/schema/pgsql.sql b/components/db_ido_pgsql/schema/pgsql.sql
@@ -1420,7 +1420,6 @@ ALTER TABLE icinga_servicechecks ADD COLUMN endpoint_object_id bigint default NU
 ALTER TABLE icinga_statehistory ADD COLUMN endpoint_object_id bigint default NULL;
 ALTER TABLE icinga_systemcommands ADD COLUMN endpoint_object_id bigint default NULL;
 
-
 -- -----------------------------------------
 -- add index (delete)
 -- -----------------------------------------

diff --git a/lib/base/dynamicobject.cpp b/lib/base/dynamicobject.cpp
@@ -44,7 +44,7 @@ INITIALIZE_ONCE(&DynamicObject::StaticInitialize);
 
 boost::signals2::signal<void (const DynamicObject::Ptr&)> DynamicObject::OnStarted;
 boost::signals2::signal<void (const DynamicObject::Ptr&)> DynamicObject::OnStopped;
-boost::signals2::signal<void (const DynamicObject::Ptr&)> DynamicObject::OnStateChanged;
+boost::signals2::signal<void (const DynamicObject::Ptr&, const String&)> DynamicObject::OnStateChanged;
 boost::signals2::signal<void (const DynamicObject::Ptr&, const String&, bool)> DynamicObject::OnAuthorityChanged;
 
 void DynamicObject::StaticInitialize(void)

diff --git a/lib/base/dynamicobject.h b/lib/base/dynamicobject.h
@@ -56,7 +56,7 @@ class I2_BASE_API DynamicObject : public ObjectImpl<DynamicObject>
 
 	static boost::signals2::signal<void (const DynamicObject::Ptr&)> OnStarted;
 	static boost::signals2::signal<void (const DynamicObject::Ptr&)> OnStopped;
-	static boost::signals2::signal<void (const DynamicObject::Ptr&)> OnStateChanged;
+	static boost::signals2::signal<void (const DynamicObject::Ptr&, const String&)> OnStateChanged;
 	static boost::signals2::signal<void (const DynamicObject::Ptr&, const String&, bool)> OnAuthorityChanged;
 
 	Value InvokeMethod(const String& method, const std::vector<Value>& arguments);

diff --git a/lib/db_ido/dbobject.cpp b/lib/db_ido/dbobject.cpp
@@ -21,6 +21,7 @@
 #include "db_ido/dbtype.h"
 #include "db_ido/dbvalue.h"
 #include "icinga/service.h"
+#include "cluster/endpoint.h"
 #include "base/dynamictype.h"
 #include "base/objectlock.h"
 #include "base/utility.h"
@@ -41,7 +42,7 @@ DbObject::DbObject(const shared_ptr<DbType>& type, const String& name1, const St
 void DbObject::StaticInitialize(void)
 {
 	/* triggered in ProcessCheckResult(), requires UpdateNextCheck() to be called before */
-	DynamicObject::OnStateChanged.connect(boost::bind(&DbObject::StateChangedHandler, _1));
+	DynamicObject::OnStateChanged.connect(boost::bind(&DbObject::StateChangedHandler, _1, _2));
 }
 
 void DbObject::SetObject(const DynamicObject::Ptr& object)
@@ -95,10 +96,12 @@ void DbObject::SendConfigUpdate(void)
 	OnConfigUpdate();
 }
 
-void DbObject::SendStatusUpdate(void)
+void DbObject::SendStatusUpdate(const String& authority)
 {
 	Dictionary::Ptr fields = GetStatusFields();
 
+	Endpoint::Ptr endpoint = Endpoint::GetByName(authority);
+
 	if (!fields)
 		return;
 
@@ -109,6 +112,10 @@ void DbObject::SendStatusUpdate(void)
 	query.Fields = fields;
 	query.Fields->Set(GetType()->GetIDColumn(), GetObject());
 	query.Fields->Set("instance_id", 0); /* DbConnection class fills in real ID */
+
+	if (endpoint)
+		query.Fields->Set("endpoint_object_id", endpoint);
+
 	query.Fields->Set("status_update_time", DbValue::FromTimestamp(Utility::GetTime()));
 	query.WhereCriteria = make_shared<Dictionary>();
 	query.WhereCriteria->Set(GetType()->GetIDColumn(), GetObject());
@@ -183,12 +190,12 @@ DbObject::Ptr DbObject::GetOrCreateByObject(const DynamicObject::Ptr& object)
 	return dbobj;
 }
 
-void DbObject::StateChangedHandler(const DynamicObject::Ptr& object)
+void DbObject::StateChangedHandler(const DynamicObject::Ptr& object, const String& authority)
 {
 	DbObject::Ptr dbobj = GetOrCreateByObject(object);
 
 	if (!dbobj)
 		return;
 
-	dbobj->SendStatusUpdate();
+	dbobj->SendStatusUpdate(authority);
 }
diff --git a/lib/db_ido/dbobject.h b/lib/db_ido/dbobject.h
@@ -79,7 +79,7 @@ class I2_DB_IDO_API DbObject : public Object
 	static boost::signals2::signal<void (const DbQuery&)> OnQuery;
 
 	void SendConfigUpdate(void);
-	void SendStatusUpdate(void);
+	void SendStatusUpdate(const String& authority = String());
 
 	double GetLastConfigUpdate(void) const;
 	double GetLastStatusUpdate(void) const;
@@ -100,7 +100,7 @@ class I2_DB_IDO_API DbObject : public Object
 	double m_LastConfigUpdate;
 	double m_LastStatusUpdate;
 
-	static void StateChangedHandler(const DynamicObject::Ptr& object);
+	static void StateChangedHandler(const DynamicObject::Ptr& object, const String& authority);
 
 	friend class DbType;
 };

diff --git a/lib/icinga/service-check.cpp b/lib/icinga/service-check.cpp
@@ -405,7 +405,7 @@ void Service::ProcessCheckResult(const CheckResult::Ptr& cr, const String& autho
 	OnNewCheckResult(GetSelf(), cr, authority);
 
 	/* signal status updates to for example db_ido */
-	OnStateChanged(GetSelf());
+	OnStateChanged(GetSelf(), authority);
 
 	if (hardChange)
 		OnStateChange(GetSelf(), cr, StateTypeHard, authority);