Skip to content

Commit

Permalink
DB IDO: Make sure that all result sets are processed before sending a…
Browse files Browse the repository at this point in the history
…nother query

fixes #12597
  • Loading branch information
Michael Friedrich authored and gunnarbeutner committed Nov 23, 2016
1 parent 0342197 commit ad0604d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 5 deletions.
25 changes: 20 additions & 5 deletions lib/db_ido_mysql/idomysqlconnection.cpp
Expand Up @@ -512,20 +512,21 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
);
}

std::vector<IdoMysqlResultInfo> resultSets;

for (std::vector<IdoAsyncQuery>::size_type i = offset; i < offset + count; i++) {
const IdoAsyncQuery& aq = queries[i];

MYSQL_RES *result = mysql_store_result(&m_Connection);

m_AffectedRows = mysql_affected_rows(&m_Connection);

int affectedRows = mysql_affected_rows(&m_Connection);
IdoMysqlResult iresult;

if (!result) {
if (mysql_field_count(&m_Connection) > 0) {
std::ostringstream msgbuf;
String message = mysql_error(&m_Connection);
msgbuf << "Error \"" << message << "\" when executing query \"" << aq.Query << "\"";
msgbuf << "Error \"" << message << "\" when checking field count \"" << aq.Query << "\"";
Log(LogCritical, "IdoMysqlConnection", msgbuf.str());

BOOST_THROW_EXCEPTION(
Expand All @@ -537,8 +538,11 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
} else
iresult = IdoMysqlResult(result, std::ptr_fun(mysql_free_result));

if (aq.Callback)
aq.Callback(iresult);
IdoMysqlResultInfo resultInfo;
resultInfo.Result = iresult;
resultInfo.AffectedRows = affectedRows;

resultSets.push_back(resultInfo);

if (mysql_next_result(&m_Connection) > 0) {
std::ostringstream msgbuf;
Expand All @@ -554,6 +558,17 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
}
}

for (std::vector<IdoAsyncQuery>::size_type i = offset; i < offset + count; i++) {
const IdoAsyncQuery& aq = queries[i];

const IdoMysqlResultInfo ri = resultSets[i - offset];

m_AffectedRows = ri.AffectedRows;

if (aq.Callback)
aq.Callback(ri.Result);
}

offset += count;
}
}
Expand Down
6 changes: 6 additions & 0 deletions lib/db_ido_mysql/idomysqlconnection.hpp
Expand Up @@ -39,6 +39,12 @@ struct IdoAsyncQuery
IdoAsyncCallback Callback;
};

struct IdoMysqlResultInfo
{
IdoMysqlResult Result;
int AffectedRows;
};

/**
* An IDO MySQL database connection.
*
Expand Down

0 comments on commit ad0604d

Please sign in to comment.