Always reset Boost beast buffer in HttpServerConnection#ProcessMessages

refs #7431
Icinga · Sep 6, 2019 · eabba2d · eabba2d
1 parent 1f50a70
commit eabba2d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/remote/httpserverconnection.cpp b/lib/remote/httpserverconnection.cpp
@@ -475,6 +475,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
 
 			response.set(http::field::server, l_ServerHeader);
 
+			// Best practice is to always reset the buffer.
+			buf = {};
 			if (!EnsureValidHeaders(*m_Stream, buf, parser, response, yc)) {
 				break;
 			}
@@ -520,6 +522,8 @@ void HttpServerConnection::ProcessMessages(boost::asio::yield_context yc)
 				break;
 			}
 
+			// Best practice is to always reset the buffer.
+			buf = {};
 			if (!EnsureValidBody(*m_Stream, buf, parser, authenticatedUser, response, yc)) {
 				break;
 			}