Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong executable name for check_systemd plugin #9547

Open
lyknode opened this issue Oct 23, 2022 · 3 comments · May be fixed by #10035
Open

Wrong executable name for check_systemd plugin #9547

lyknode opened this issue Oct 23, 2022 · 3 comments · May be fixed by #10035
Assignees
Labels
area/itl Template Library CheckCommands bug Something isn't working

Comments

@lyknode
Copy link
Contributor

lyknode commented Oct 23, 2022

Hi,

In itl/plugins-contrib.d/systemd.conf, the command definition for check_systemd plugin looks for check_systemd.py.

However, in upstream README.rst, upstream icinga2 command definition and in Debian, the plugin is installed as check_systemd.

Would it be possible to update the plugin name in the docs and the command definition to match the command name as defined by upstream and installed in Debian?

Let me know if you want me to provide the corresponding PR.

Best,

@krishnacx
Copy link

Please empower me to work on this issue.

@julianbrost
Copy link
Contributor

Please empower me to work on this issue.

You don't need any special permissions to create pull requests against this repo.

But let's first sort out if we want to change this. Has that project renamed the command in the meantime or does this discrepancy exist from the beginning? @yayayayaka As you added the command, do you know of any distributions that provide this check with the .py extension in the command name?

@yayayayaka
Copy link
Contributor

This discrepancy exists since the beginning and we should fix that.

yayayayaka added a commit to yayayayaka/icinga2 that referenced this issue Nov 5, 2022
The check_systemd plugin is packaged as `check_systemd` (without the
`.py` extension) in the major Linux distributions, as reported in Icinga#9547.

Resolves Icinga#9547
yayayayaka added a commit to yayayayaka/icinga2 that referenced this issue Nov 5, 2022
The check_systemd plugin is packaged as `check_systemd` (without the
`.py` extension) in the major Linux distributions, as reported in Icinga#9547.

Resolves Icinga#9547
@Al2Klimov Al2Klimov added the area/itl Template Library CheckCommands label Jan 3, 2023
@Al2Klimov Al2Klimov added the bug Something isn't working label May 2, 2023
@Al2Klimov Al2Klimov added the good first issue Good for newcomers label Dec 13, 2023
oxzi added a commit that referenced this issue Apr 3, 2024
The executable name for check_systemd's dropped the `.py` suffix for
version 2.0.3[0], released in April 2019[1]. However, the old name is
still being referenced, both in documentation as well as in the ITL's
CheckCommand's command, making it unusable.

Closes #9547.

[0]: Josef-Friedrich/check_systemd@v2.0.2...v2.0.3#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
[1]: https://github.com/Josef-Friedrich/check_systemd/releases/tag/v2.0.3
@Al2Klimov Al2Klimov removed the good first issue Good for newcomers label Apr 16, 2024
oxzi added a commit that referenced this issue May 8, 2024
The executable name for check_systemd's dropped the `.py` suffix for
version 2.0.3[0], released in April 2019[1]. However, the old name is
still being referenced, both in documentation as well as in the ITL's
CheckCommand's command, making it unusable.

Closes #9547.

[0]: Josef-Friedrich/check_systemd@v2.0.2...v2.0.3#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
[1]: https://github.com/Josef-Friedrich/check_systemd/releases/tag/v2.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands bug Something isn't working
Projects
None yet
6 participants