Windows agent wizard: allow to change the parent zone name #10091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/distributed
Al2Klimov
force-pushed
the
windows-agents-assume-parent-nodes-being-in-master-zone-9602
branch
from
8d85ed3
to
2c3fbfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9602
TODO
The main part is 8d85ed3
As you can see, I can input my own zone and it affects zones.conf:
8708a1f doesn't matter
While on the main issue, which implies fully re-creating screenshots in doc/images/distributed-monitoring, I also removed the space which I introduced here: https://github.com/Icinga/icinga2/pull/9703/files#diff-ba5eb9549040f718934486398dfdd86ae3b2825e889222820ec2eb87ce38beb3
I just moved a few elements in a visual editor there. I strongly suggest you to look at the commits separately and to hide whitespace if possible.