Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass raw performance data in 'process-check-result' API action #6077

Merged
merged 1 commit into from Feb 6, 2018

Conversation

dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Feb 6, 2018

This is how data is coming from Icinga Web 2 and still a valid input
type.

fixes #4786

This is how data is coming from Icinga Web 2 and still a valid input
type.

fixes #4786
@dnsmichi dnsmichi added bug Something isn't working area/api REST API labels Feb 6, 2018
@dnsmichi dnsmichi added this to the 2.9.0 milestone Feb 6, 2018
Copy link
Contributor

@Crunsher Crunsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimming over it it seems like we do not need error handling for this, an invalid string would just lead to invalid data - causing it to fail later with a proper error message.

@dnsmichi dnsmichi merged commit 7c66f88 into master Feb 6, 2018
@dnsmichi dnsmichi deleted the fix/api-actions-cr-perfdata branch February 6, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api REST API bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev.icinga.com #13197] API: Command process-check-result fails if it contains performance data
2 participants