Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak build against Boost 1.67 #6230

Merged
merged 1 commit into from Apr 16, 2018
Merged

Unbreak build against Boost 1.67 #6230

merged 1 commit into from Apr 16, 2018

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Apr 15, 2018

@jbeich
Explicitly use long with boost::posix_time
106be29 
In file included from lib/base/base_unity.cpp:61:
lib/base/timer.cpp:295:31: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
                        l_TimerCV.timed_wait(lock, boost::posix_time::milliseconds(wait * 1000));
                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from lib/remote/remote_unity.cpp:19:
lib/remote/eventqueue.cpp:111:30: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
                if (!m_CV.timed_wait(lock, boost::posix_time::milliseconds(timeout * 1000)))
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from lib/checker/checker_unity.cpp:1:
lib/checker/checkercomponent.cpp:128:26: error: no matching conversion for functional-style cast from 'double' to 'boost::posix_time::milliseconds' (aka 'subsecond_duration<boost::posix_time::time_duration, 1000>')
                        m_CV.timed_wait(lock, boost::posix_time::milliseconds(wait * 1000));
                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/boost/date_time/time_duration.hpp:270:30: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'double' to 'const boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>' for 1st argument
  class BOOST_SYMBOL_VISIBLE subsecond_duration : public base_duration
                             ^
/usr/local/include/boost/date_time/time_duration.hpp:270:30: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'double' to 'boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>' for 1st argument
/usr/local/include/boost/date_time/time_duration.hpp:286:59: note: candidate template ignored: disabled by 'enable_if' [with T = double]
                                typename boost::enable_if<boost::is_integral<T>, void>::type* = 0) :
                                                          ^
@Crunsher Crunsher self-requested a review April 16, 2018 07:33
@Crunsher Crunsher added the core/build-fix Follow-up fix, not released yet label Apr 16, 2018
Crunsher
Crunsher approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@Crunsher Crunsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@Crunsher Crunsher merged commit b76ef91 into Icinga:master Apr 16, 2018
@Crunsher Crunsher added this to the 2.8.3 milestone Apr 16, 2018
@dnsmichi dnsmichi mentioned this pull request Apr 17, 2018
Closed
@dnsmichi dnsmichi added the backported Fix was included in a bugfix release label Apr 17, 2018
myungjoo added a commit to myungjoo/tizenport-ros-roscpp-core that referenced this pull request Feb 19, 2020
@myungjoo
Fix build errors with recent boost libraries (>= 1.67)
665e31c 
With boostorg/date_time@f9f2aaf5216c
we need to update the usage of duration.
Reference: Icinga/icinga2#6230

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo added a commit to myungjoo/tizenport-ros-roscpp-core that referenced this pull request Feb 19, 2020
@myungjoo
Fix build errors with recent boost libraries (>= 1.67)
b3fb73f 
With boostorg/date_time@f9f2aaf5216c
we need to update the usage of duration.
Reference: Icinga/icinga2#6230

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
myungjoo added a commit to myungjoo/tizenport-ros-roscpp-core that referenced this pull request Feb 19, 2020
@myungjoo
Fix build errors with recent boost libraries (>= 1.67)
b5a4739 
With boostorg/date_time@f9f2aaf5216c
we need to update the usage of duration.
Reference: Icinga/icinga2#6230

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
@myungjoo myungjoo mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crunsher Crunsher Crunsher approved these changes

Assignees
No one assigned
Labels
backported Fix was included in a bugfix release core/build-fix Follow-up fix, not released yet
Projects
None yet
Milestone
2.8.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbeich @Crunsher @dnsmichi