Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxdbWriter: skip non-resolvable tags #7353

Merged
merged 1 commit into from Aug 7, 2019

Conversation

Al2Klimov
Copy link
Member

fixes #7341

@Al2Klimov Al2Klimov self-assigned this Jul 23, 2019
@Al2Klimov
Copy link
Member Author

Test protocol

/etc/icinga2/features-available/influxdb.conf

object InfluxdbWriter "influxdb" {
  host = "10.211.55.2"
  port = 8088
  database = "icinga2"
  flush_threshold = 1024
  flush_interval = 10s
  username = "icinga2"
  password = "icinga2"
  host_template = {
    measurement = "$host.check_command$"
    tags = {
      hostname = "$host.name$"
      lolcat = "$lolcat$"
    }
  }
  service_template = {
    measurement = "$service.check_command$"
    tags = {
      hostname = "$host.name$"
      service = "$service.name$"
      lolcat = "$lolcat$"
    }
  }
}

Before/After

> select * from hostalive;
name: hostalive
time                hostname                            lolcat   metric unit    value
----                --------                            ------   ------ ----    -----
1563899940000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899940000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000055
1563899945000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899945000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000087
1563899950000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899950000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000062
1563899955000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899955000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000103
1563899960000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899960000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000058
1563899965000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899965000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000063
1563899971000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899971000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000061
1563899976000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899976000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000071
1563899981000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899981000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000458
1563899986000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899986000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000061
1563899991000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899991000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000061
1563899996000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563899996000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000073
1563900001000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900001000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000097
1563900006000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900006000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000059
1563900012000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900012000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000079
1563900017000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900017000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.00007
1563900022000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900022000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.00006
1563900027000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900027000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000075
1563900032000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900032000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000105
1563900037000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900037000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000098
1563900042000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900042000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000054
1563900047000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900047000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.00009
1563900053000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900053000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000071
1563900058000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900058000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000084
1563900063000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900063000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000078
1563900068000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900068000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000064
1563900073000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900073000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000071
1563900078000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900078000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.00008
1563900083000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900083000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000065
1563900088000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900088000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000086
1563900093000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900093000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000061
1563900099000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900099000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000056
1563900104000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900104000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000059
1563900109000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900109000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000108
1563900114000000000 icinga2_default_1559655014332_76988 $lolcat$ pl     percent 0
1563900114000000000 icinga2_default_1559655014332_76988 $lolcat$ rta    seconds 0.000063
1563900225000000000 icinga2_default_1559655014332_76988          pl     percent 0
1563900225000000000 icinga2_default_1559655014332_76988          rta    seconds 0.000089
1563900230000000000 icinga2_default_1559655014332_76988          pl     percent 0
1563900230000000000 icinga2_default_1559655014332_76988          rta    seconds 0.000057
1563900235000000000 icinga2_default_1559655014332_76988          pl     percent 0
1563900235000000000 icinga2_default_1559655014332_76988          rta    seconds 0.000064
1563900240000000000 icinga2_default_1559655014332_76988          pl     percent 0
1563900240000000000 icinga2_default_1559655014332_76988          rta    seconds 0.000065
1563900245000000000 icinga2_default_1559655014332_76988          pl     percent 0
1563900245000000000 icinga2_default_1559655014332_76988          rta    seconds 0.000061

@Al2Klimov Al2Klimov removed their assignment Jul 23, 2019
@Al2Klimov Al2Klimov requested a review from dnsmichi July 23, 2019 16:48
@dnsmichi
Copy link
Contributor

I'd like to fix the code base, the Clone() with later looping and removing is quite an overhead and not conforming to our code style. I'll look into this after 2.11 release times.

@Al2Klimov Al2Klimov self-assigned this Jul 24, 2019
@Al2Klimov Al2Klimov removed the request for review from dnsmichi July 24, 2019 08:21
@Al2Klimov Al2Klimov removed their assignment Jul 24, 2019
@Al2Klimov Al2Klimov requested a review from dnsmichi July 24, 2019 08:45
@dnsmichi dnsmichi added this to the 2.12.0 milestone Jul 26, 2019
@dnsmichi dnsmichi modified the milestones: 2.12.0, 2.11.0 Aug 7, 2019
@dnsmichi
Copy link
Contributor

dnsmichi commented Aug 7, 2019

Exception made, will merge this for 2.11 with the extended RC test window.

@dnsmichi dnsmichi merged commit d840069 into master Aug 7, 2019
@dnsmichi dnsmichi deleted the bugfix/influxdbwriter-skip-tags-7341 branch August 7, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

influxdbwriter is not skipping tags when the corresponding variable doesn't exist
2 participants