Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConfigCompiler#m_LexBuffer a String #7769

Merged
merged 1 commit into from Feb 10, 2020
Merged

Make ConfigCompiler#m_LexBuffer a String #7769

merged 1 commit into from Feb 10, 2020

Conversation

Al2Klimov
Copy link
Member

... to reduce malloc()s.

@Al2Klimov Al2Klimov mentioned this pull request Jan 21, 2020
Closed
@Al2Klimov Al2Klimov requested review from N-o-X and htriem and removed request for N-o-X January 21, 2020 13:10
@dnsmichi dnsmichi self-requested a review February 10, 2020 15:27
@dnsmichi dnsmichi added the core/quality Improve code, libraries, algorithms, inline docs label Feb 10, 2020
@dnsmichi dnsmichi added this to the 2.12.0 milestone Feb 10, 2020
dnsmichi
dnsmichi approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@dnsmichi dnsmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@dnsmichi dnsmichi merged commit 2f82047 into master Feb 10, 2020
@dnsmichi dnsmichi deleted the bugfix/m_lexbuffer branch February 10, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

@htriem htriem Awaiting requested review from htriem

Assignees
No one assigned
Labels
core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Al2Klimov @dnsmichi