Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: provide shorter and batch-ier instructions on how to setup a Windows dev env #8400

Merged
merged 1 commit into from Nov 9, 2020
Merged

Docs: provide shorter and batch-ier instructions on how to setup a Windows dev env #8400

merged 1 commit into from Nov 9, 2020

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added area/documentation End-user or developer help area/windows Windows agent and plugins labels Oct 28, 2020
@icinga-probot icinga-probot bot added this to the 2.13.0 milestone Oct 28, 2020
@Al2Klimov Al2Klimov added this to To review in v2.13.0 merge window via automation Oct 28, 2020
julianbrost
julianbrost requested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could generalize the win-dev.ps1 file so that it can also be used for setting up the build environment in GitHub Actions? In this case it would also have to support 32 bit. This would probably avoid some duplication.

Is there something similar to set -e in PowerShell, i.e. stop on errors? In my test run, downloading Boost ran into a timeout and it continued with downloading OpenSSL.

Also I'm wondering why GitHub show my commit as part of this PR even though it is already merged to master.

doc/win-dev.ps1 Outdated Show resolved Hide resolved
doc/21-development.md Outdated Show resolved Hide resolved
doc/21-development.md Outdated Show resolved Hide resolved
v2.13.0 merge window automation moved this from To review to Changes requested Oct 29, 2020
@Al2Klimov Al2Klimov marked this pull request as draft October 29, 2020 10:41
@Al2Klimov
Copy link
Member Author

  1. Let's return to this question once one of the PRs has been merged.
  2. Done. Please re-test.

@Al2Klimov Al2Klimov mentioned this pull request Oct 29, 2020
Open
@Al2Klimov Al2Klimov assigned Al2Klimov and bobapple and unassigned Al2Klimov and bobapple Oct 29, 2020
@Al2Klimov Al2Klimov force-pushed the feature/doc-win-dev branch 2 times, most recently from fb84260 to f65293e Compare October 30, 2020 13:12
@Al2Klimov Al2Klimov removed the request for review from julianbrost October 30, 2020 13:13
@Al2Klimov Al2Klimov removed their assignment Nov 6, 2020
@Al2Klimov Al2Klimov marked this pull request as ready for review November 6, 2020 12:28
v2.13.0 merge window automation moved this from Changes requested to Approved Nov 9, 2020
@Al2Klimov Al2Klimov merged commit a0c4830 into master Nov 9, 2020
v2.13.0 merge window automation moved this from Approved to Merged Nov 9, 2020
@icinga-probot icinga-probot bot deleted the feature/doc-win-dev branch November 9, 2020 16:20
@Al2Klimov Al2Klimov mentioned this pull request Nov 13, 2020
Closed
This was referenced Jul 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobapple bobapple bobapple left review comments

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/documentation End-user or developer help area/windows Windows agent and plugins
Projects
No open projects
v2.13.0 merge window
  
Merged
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Al2Klimov @julianbrost @bobapple