Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITL: Add systemd CheckCommand #8568

Merged
merged 1 commit into from Jan 15, 2021

Conversation

yayayayaka
Copy link
Contributor

Merging this pull request will introduce a systemd CheckCommand and related documentation for the check_systemd.py plugin.

@icinga-probot icinga-probot bot added this to the 2.13.0 milestone Dec 15, 2020
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yayayayaka and thank you for contributing!

itl/plugins-contrib.d/systemd.conf Outdated Show resolved Hide resolved
itl/plugins-contrib.d/systemd.conf Outdated Show resolved Hide resolved
itl/plugins-contrib.d/systemd.conf Outdated Show resolved Hide resolved
@Al2Klimov
Copy link
Member

@Yonas-net Verify your doubts by actually running the plugin.

@yhabteab
Copy link
Member

Oh, sorry it does work as it is right now. I have just tested it.

Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! except that maybe you could set all the default values here too but @Al2Klimov might know better.

itl/plugins-contrib.d/systemd.conf Outdated Show resolved Hide resolved
itl/plugins-contrib.d/systemd.conf Show resolved Hide resolved
itl/plugins-contrib.d/systemd.conf Outdated Show resolved Hide resolved
doc/10-icinga-template-library.md Outdated Show resolved Hide resolved
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits.

The [check_systemd.py](https://github.com/Josef-Friedrich/check_systemd)
plugin will report a degraded system to your monitoring solution. It
requires only the
[nagiosplugin](https://nagiosplugin.readthedocs.io/en/stable) library.
@Al2Klimov Al2Klimov merged commit a55c7d4 into Icinga:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants