ConfigPackageUtility::ValidateName: replace broken regex #8825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old validation regex matched if the name consists only of invalid character, not that it does not contain them, i.e. something like "foo/bar" was considered valid.
This commit replaces the regex with a check that all characters in the name are allowed characters.
Backwards compatibility
This change could cause trouble in existing installations as package names could have worked before that weren't supposed to be valid. We could also be more permissive then what I suppose was intended with the original implementation.
Before
Running the new tests with the old implementation:
After
New tests pass