Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginUtility: Fix PerfData parsing for values separated with multiple spaces #8969

Merged
merged 2 commits into from
May 22, 2023
Merged

PluginUtility: Fix PerfData parsing for values separated with multiple spaces #8969

merged 2 commits into from
May 22, 2023

Commits on Apr 5, 2023

  1. PluginUtility: Fix PerfData don't get parsed correctly 

    The problem was that some PerfData labels contained several whitespace characters,
not just one, and therefore it was parsed incorrectly in `SplitPerfdata()`. I.e. the condition
in line 144 checks whether the first and last character is a normal quote, but since the
label can contain spaces at the beginning and at the end respectively, this caused the problems.

This PR fixes the problem by removing all occurring whitespace from the beginning and end,
before starting to parse the actual label.
    @yhabteab
    yhabteab committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    24d95e1 View commit details
    Browse the repository at this point in the history

  2. Test: Add multiline PerfData test case

    @yhabteab
    yhabteab committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e7c5554 View commit details
    Browse the repository at this point in the history