Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include to fix non-unity builds #9092

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

julianbrost
Copy link
Contributor

This commit fixes the following build error:

[ 55%] Building CXX object lib/icinga/CMakeFiles/icinga.dir/usergroup.cpp.o
lib/icinga/usergroup.cpp:79:24: error: incomplete type ‘icinga::Notification’ used in nested name specifier
   79 | std::set<Notification::Ptr> UserGroup::GetNotifications() const
      |                        ^~~

Note that this is also broken in 2.13.2 (#9009 (comment)) so the fix should also be released in 2.13.3.

This commit fixes the following build error:

    [ 55%] Building CXX object lib/icinga/CMakeFiles/icinga.dir/usergroup.cpp.o
    lib/icinga/usergroup.cpp:79:24: error: incomplete type ‘icinga::Notification’ used in nested name specifier
       79 | std::set<Notification::Ptr> UserGroup::GetNotifications() const
          |                        ^~~
@julianbrost julianbrost added core/build-fix Follow-up fix, not released yet consider backporting Should be considered for inclusion in a bugfix release labels Nov 17, 2021
@cla-bot cla-bot bot added the cla/signed label Nov 17, 2021
@julianbrost julianbrost added this to the 2.14.0 milestone Nov 17, 2021
@Al2Klimov
Copy link
Member

Note that this is also broken in 2.13.2 (#9009 (comment)) so the fix should also be released in 2.13.3.

What for? Where do we have non-unity builds?

@julianbrost
Copy link
Contributor Author

We don't, otherwise we would have noticed ourselves. It should work nonetheless. But nothing for which we'd need an immediate release or something like that.

@julianbrost julianbrost merged commit 8cde21d into master Nov 19, 2021
@julianbrost julianbrost added backported Fix was included in a bugfix release and removed consider backporting Should be considered for inclusion in a bugfix release labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Fix was included in a bugfix release cla/signed core/build-fix Follow-up fix, not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants