Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDO MySQL: explicitly use latin1 #9312

Merged
merged 2 commits into from Apr 6, 2022
Merged

IDO MySQL: explicitly use latin1 #9312

merged 2 commits into from Apr 6, 2022

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Mar 31, 2022 •
edited

for the case the MySQL client lib is compiled with another default
not to turn Unicode chars into ??.

Backport of #9311 #9314

@Al2Klimov
IDO MySQL: explicitly use latin1
245fbad 
for the case the MySQL client lib is compiled with another default
not to turn Unicode chars into ??.
@cla-bot cla-bot bot added the cla/signed label Mar 31, 2022
@icinga-probot icinga-probot bot added this to the 2.13.3 milestone Mar 31, 2022
@icinga-probot icinga-probot bot added area/db-ido Database output bug Something isn't working labels Mar 31, 2022
@Al2Klimov Al2Klimov requested a review from lippserd March 31, 2022 14:45
@Al2Klimov Al2Klimov requested review from julianbrost and removed request for lippserd March 31, 2022 16:32
julianbrost
julianbrost approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as in #9314 (review)

@julianbrost
Copy link
Contributor

And obviously GitHub Actions can't handle multiple PRs with the same head...

@julianbrost julianbrost merged commit 24f2d8c into support/2.13 Apr 6, 2022
@icinga-probot icinga-probot bot deleted the 9308 branch April 6, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/db-ido Database output bug Something isn't working cla/signed
Projects
None yet
Milestone
2.13.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Al2Klimov @julianbrost