CheckStatistics: Reflect disabled active checks

[flourish86]

Describe the bug

Disabling active checks afftects the “next check” value from the check statistics widget. Currently this leads to negative values for the “next check” or when the view is updated wrong values

To Reproduce

1. Open a service/host detail view
2. disabled active checks
3. Wait until the check interval is over to see the negative “Next Check” value

Expected behavior

We should consider the Check Statistics widget to reflect that active checks are disabled.

Screenshots

[nilmerg]

Passive checks are on though. What happens when disabling them as well?

[nilmerg]

With passive checks on ...

it looks now this way: (The counter only goes negative until the next autorefresh runs, which is fine IMHO)

Prior

After

With passive checks off ...

t works the same

Prior

After

Conclusion

With passive checks on the view is fine since the next update timer doesn't run into negative values. (Unless the autorefresh is disabled..) And as long as passive checks are on, they might come in and there is no reason for indicating this "standard" behavior.

With passive checks off however, it behaves the same. As then no update is accepted (Unless someone clicks on Check now, which forces a check) the timer runs into it's next update and resets on and on. We should reflect that by suspending the Now cursor and by showing not-scheduled (visually similar to empty-state) in the next check bubble.

[flourish86]

This is how the Widget could look, if active AND passive checks are disabled. We figured, that it wouldn’t make sense to vizualize that only one is disabled.

To make it more obvious, this could be an alternative.

[nilmerg]

Pragmatic, as always 😂