Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*Miss some results?* suggestion still shows up if not required #969

Closed
nilmerg opened this issue Feb 2, 2024 · 1 comment · Fixed by #970
Closed

*Miss some results?* suggestion still shows up if not required #969

nilmerg opened this issue Feb 2, 2024 · 1 comment · Fixed by #970
Assignees
@nilmerg
Labels
bug Something isn't working ref/IP
Milestone
1.1.2

Comments

@nilmerg
Copy link
Member

nilmerg commented Feb 2, 2024

Describe the bug

The suggestion to try a different filter still shows up in cases where the filter doesn't need transformation.

To Reproduce

Have a URL with a filter that is formatted either in strict mode or with unnecessary parentheses.

Expected behavior

No suggestion is made.

Your Environment

  • Icinga DB Web version (System - About): 1.1.1
@nilmerg nilmerg added bug Something isn't working ref/IP labels Feb 2, 2024
@nilmerg nilmerg added this to the 1.1.2 milestone Feb 2, 2024
@nilmerg nilmerg self-assigned this Feb 2, 2024
@nilmerg
Copy link
Member Author

nilmerg commented Feb 2, 2024

ref/IP/49039

nilmerg added a commit that referenced this issue Feb 2, 2024
@nilmerg
migrate/search-url: Prevent further false-positives
e81527a 
See included comment

fixes #969
@nilmerg nilmerg mentioned this issue Feb 2, 2024
Merged
nilmerg added a commit that referenced this issue Mar 14, 2024
@nilmerg
migrate/search-url: Prevent further false-positives
c672b32 
See included comment

fixes #969
RincewindsHat pushed a commit to RincewindsHat/icingadb-web that referenced this issue Mar 15, 2024
@nilmerg @RincewindsHat
migrate/search-url: Prevent further false-positives
29e7016 
See included comment

fixes Icinga#969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
bug Something isn't working ref/IP
Projects
None yet
Milestone
1.1.2
Development

Successfully merging a pull request may close this issue.

migrate/search-url: Prevent further false-positives Icinga/icingadb-web
1 participant
@nilmerg