Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display downtime icon independent from object state #772

Merged
merged 2 commits into from Jun 15, 2023
Merged

Display downtime icon independent from object state #772

merged 2 commits into from Jun 15, 2023

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jun 5, 2023 •
edited

resolves #706

requires: Icinga/ipl-web#156

@sukhwinder33445 sukhwinder33445 self-assigned this Jun 5, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jun 5, 2023
@sukhwinder33445 sukhwinder33445 added the enhancement New feature or improvement label Jun 5, 2023
@sukhwinder33445 sukhwinder33445 force-pushed the feature/display-downtime-icon-for-every-state branch from 9ef6db1 to 4483188 Compare June 5, 2023 13:02
flourish86
flourish86 requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@flourish86 flourish86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look. The icon in the detail header ist placed in the wrong visual. It should take place in the current state visual, like in the list.

Screenshot 2023-06-05 at 15 34 11

@nilmerg nilmerg added the area/representation Affects the representation of information label Jun 7, 2023
@nilmerg nilmerg added this to the 1.1.0 milestone Jun 7, 2023
nilmerg
nilmerg requested changes Jun 7, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement State::getIcon(): ?Icon, should simplify this change significantly.

@sukhwinder33445 sukhwinder33445 force-pushed the feature/display-downtime-icon-for-every-state branch from 4483188 to fa92c8f Compare June 7, 2023 09:58
nilmerg
nilmerg requested changes Jun 7, 2023
View reviewed changes
library/Icingadb/Model/State.php Outdated Show resolved Hide resolved
library/Icingadb/Model/State.php Outdated Show resolved Hide resolved
library/Icingadb/Model/State.php Outdated Show resolved Hide resolved
library/Icingadb/Model/State.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/StateChange.php Outdated Show resolved Hide resolved
@sukhwinder33445
Show downtime icon independent from object state
dd2b286 
* Replace `getHandledIcon()` with `State::getIcon()`.

Change the missing order of handled state icons

ref #635
@sukhwinder33445 sukhwinder33445 force-pushed the feature/display-downtime-icon-for-every-state branch 2 times, most recently from f882656 to 661542a Compare June 7, 2023 14:16
nilmerg
nilmerg requested changes Jun 12, 2023
View reviewed changes
library/Icingadb/Widget/StateChange.php Outdated Show resolved Hide resolved
@sukhwinder33445 sukhwinder33445 force-pushed the feature/display-downtime-icon-for-every-state branch from 661542a to f541ca4 Compare June 14, 2023 08:46
@nilmerg nilmerg merged commit 9996f56 into master Jun 15, 2023
12 checks passed
@nilmerg nilmerg deleted the feature/display-downtime-icon-for-every-state branch June 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@flourish86 flourish86 Awaiting requested review from flourish86

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/representation Affects the representation of information cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Symbol doesn't show that Host/Service is in Downtime when it's okay
3 participants
@sukhwinder33445 @flourish86 @nilmerg