MySQL/MariaDB: Fix icingadb_schema.timestamp not being UNX time
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CURRENT_TIMESTAMP()` an alias for `NOW()` returns the current date and time in the format `YYYY-MM-DD hh:mm:ss` using the session time zone. Since we are using numeric context, the value is stored in the format `YYYYMMDDhhmmss`. But actually we want to set a (millisecond) UNIX timestamp here, so we need to use `UNIX_TIMESTAMP()` instead.
julianbrost
reviewed
Mar 18, 2024
We previously incorrectly used `CURRENT_TIMESTAMP()` instead of `UNIX_TIMESTAMP()` so the timestamps need to be corrected.
lippserd
force-pushed
the
icingadb_schema-timestamp
branch
from
75b638c
to
9b213d5
Compare
julianbrost
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously incorrectly used
CURRENT_TIMESTAMP()an alias forNOW()which returns the current date and time in the formatYYYY-MM-DD hh:mm:ssusing the session time zone. Since we are using numeric context, the value is stored in the formatYYYYMMDDhhmmss. But actually we want to set a (millisecond) UNIX timestamp here, so we need to useUNIX_TIMESTAMP()instead.Since the timestamps need to be corrected, there is also a schema upgrade.