Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to another BP defined in different file is broken #245

Closed
lbetz opened this issue Sep 27, 2019 · 6 comments · Fixed by #266
Closed

Reference to another BP defined in different file is broken #245

lbetz opened this issue Sep 27, 2019 · 6 comments · Fixed by #266
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lbetz
Copy link
Member

lbetz commented Sep 27, 2019

Describe the bug

Since 2.2.0 the behaviour of the references to processes in other files changed.

To Reproduce

Provide a link to a live example, or an unambiguous set of steps to reproduce this issue. Include configuration, logs, etc. to reproduce, if relevant.

Use the following example...

Expected behavior

file_1:
bp1 = @file_2:bp2

file_2:
bp2 = host;Service
display 0;bp1;BP1

Doesn't work anymore. Only setting bp2 in file_2 to display 1 works.

@nilmerg
Copy link
Member

nilmerg commented Oct 9, 2019

Hi, please provide a working example. You can't reference bp1 in file_2 with display.

@nilmerg nilmerg added the needs-feedback We'll only proceed once we hear from you again label Oct 9, 2019
@lbetz
Copy link
Member Author

lbetz commented Oct 9, 2019

Sorry, name and display name were wrong. But what more I can say?

doesn't work anymore:
file_1:
bp1 = @file_2:bp2

file_2:
bp2 = host;Service
display 0;bp2;BP2

still works:
file_1:
bp1 = @file_2:bp2

file_2:
bp2 = host;Service
display 1;bp2;BP2

@nilmerg
Copy link
Member

nilmerg commented Oct 9, 2019

Are you able to choose bp2 during an import in the UI?

@lbetz
Copy link
Member Author

lbetz commented Oct 9, 2019 via email

@mvahani
Copy link
Contributor

mvahani commented Oct 25, 2019

In a root node you can only import process nodes from the same process, not from other processes (config files). You have to create a root node in your process and in that one you can import process nodes from other processes.
I don't know how it worked before but that's how it seems to work now in 2.2.0.

@nilmerg
Copy link
Member

nilmerg commented Nov 26, 2019

I just tried this myself and even got an error trying to view bp1 in the UI. (Mentioning this would have tremendously helped @lbetz 😉 ) Though the import is clearly working since the service's state from the imported process is properly loaded.

@mdkamijo He's trying to import a sub-node into a root node already. Importing nodes as true root nodes was never possible.

@nilmerg nilmerg added bug Something isn't working and removed needs-feedback We'll only proceed once we hear from you again labels Nov 26, 2019
@nilmerg nilmerg self-assigned this Feb 25, 2020
@nilmerg nilmerg added this to the 2.3.0 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants