Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Error when adding a node with semicolon in the varname #312

Closed
Tqnsls opened this issue Nov 23, 2021 · 1 comment · Fixed by #388
Closed

Parse Error when adding a node with semicolon in the varname #312

Tqnsls opened this issue Nov 23, 2021 · 1 comment · Fixed by #388
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Tqnsls
Copy link

Tqnsls commented Nov 23, 2021

Describe the bug

A clear and concise description of what the issue is.
One of our colleagues added a new node with a name like "vSAN Nuremberg; Citrix Worker" after saving the config the complete business-config fails and is uneditable anymore over the webbrowser only via console with vim / nano to the file in "/etc/icingaweb2/modules/businessprocess/processes"

Error is like
Parse error on /etc/icingaweb2/modules/businessprocess/processes/node.conf:: No semicolon allowed in varname

Similar behavior as in #71 and #26

Expected behavior

I can think of several options here, best way was to show an error before saving the config file with something like "nasty character semicolon (for example) was used, please check" or some change of parsing so the website and the business config / node is still editable.
Our colleagues do not have access to the businessmodule director to correct it via text editor themselves.

image

Your Environment

icingaweb2: v 2.9.3
module businessprocess: v 2.3.0
PHP: v 7.3.29
OS: RHEL 7

@nilmerg nilmerg added the bug Something isn't working label Jul 20, 2022
@nilmerg
Copy link
Member

nilmerg commented Jul 20, 2022

See also #92

@nilmerg nilmerg added this to the 2.5.0 milestone Jul 20, 2022
@sukhwinder33445 sukhwinder33445 self-assigned this Sep 29, 2022
nilmerg added a commit that referenced this issue Aug 3, 2023
nilmerg added a commit that referenced this issue Aug 7, 2023
sukhwinder33445 pushed a commit that referenced this issue Aug 7, 2023
nilmerg added a commit that referenced this issue Aug 8, 2023
@nilmerg nilmerg self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
3 participants