Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command: Don't throw error on empty nodes #440

Closed
log1-c opened this issue Mar 11, 2024 · 2 comments · Fixed by #445
Closed

CLI command: Don't throw error on empty nodes #440

log1-c opened this issue Mar 11, 2024 · 2 comments · Fixed by #445
Assignees
Labels
bug Something isn't working
Milestone

Comments

@log1-c
Copy link

log1-c commented Mar 11, 2024

Describe the bug

When running the check command against a process with an empty node the check writes an error message into the check output but keeps on working otherwise:

ERROR: ErrorException in /usr/share/icingaweb2/modules/businessprocess/application/clicommands/ProcessCommand.php:198 with message: Undefined offset: 128

To Reproduce

Have a process with an empty node:
image

Expected behavior

Don't throw error on empty nodes.

Your Environment

Icinga Web 2 2.11.3
PHP 7.3.33
Module version 2.4.1, but as the code is the same in 2.5.0 I guess an update wouldn't solve this.

@nilmerg nilmerg added the bug Something isn't working label Mar 11, 2024
@nilmerg nilmerg added this to the 2.5.1 milestone Mar 11, 2024
@sukhwinder33445
Copy link
Contributor

Hi @log1-c,
can you please share the configuration or explain the steps to reproduce this issue?

I could reproduce it if I add an empty sub node and then check the status of the parent node. But your screenshot does not contain a sub node.

@sukhwinder33445 sukhwinder33445 self-assigned this Mar 27, 2024
@log1-c
Copy link
Author

log1-c commented Mar 28, 2024

I could reproduce it if I add an empty sub node and then check the status of the parent node. But your screenshot does not contain a sub node.

That is exactly the setup. The screenshot area is too small (sorry), there is a root node above.
Here is a better one
image

  1. is the business process file
  2. is one of the configured processes
  3. is the subnode of the process where the check is producing the output
    "Application is the emtpy "sub-sub-node"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants