-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to add nodes based on filter #300
Allow to add nodes based on filter #300
Conversation
60fd999
to
9b5626c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please rebase, the change in
module.info
shouldn't be necessary - The changes in the gettext catalogs have no effect here since Icinga Web 2 v2.8.0
- Please open a PR with the same changes in https://github.com/Icinga/L10n
9b5626c
to
0a01aae
Compare
0a01aae
to
c7a4c41
Compare
c7a4c41
to
d00cf96
Compare
d00cf96
to
9d07548
Compare
9d07548
to
2eb86b0
Compare
Hello, I used "Host from filter" option with filter hostgroup="Cloud-production" and received ALL hosts in "Hosts*" list, not only these having hostgroup = Cloud-production. (This filter works well in Overview). Can you please advise how / if this function works? Thanks, Tomas |
Doesn't work anymore for me as well. Please create a new issue. |
Thanks for the nice feature! This feature would could improve the flexibility and the dynamic of the tool. Thanks in advance, Mustafa |
The feature would be nice if working. If the objects are not automatically updated based on set filters, then what are these filters for?
Tomas
From: Mustafa Mado ***@***.***>
Date: Friday, 5 August 2022 10:39
To: Icinga/icingaweb2-module-businessprocess ***@***.***>
Cc: Tomáš Bejček ***@***.***>, Comment ***@***.***>
Subject: Re: [Icinga/icingaweb2-module-businessprocess] Allow to add nodes based on filter (#300)
Thanks for the nice feature!
An improvement would be, implementing a synchronization job/feature, that updates all objects automatically based on set filters.
This feature would could improve the flexibility and the dynamic of the tool.
Thanks in advance, Mustafa
—
Reply to this email directly, view it on GitHub<#300 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AV226ZQJXWLNAFW34PWZOYDVXTHL3ANCNFSM5BGUK4DQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
My state of knowledge is, that filters are currently just being used (one time) for the first init of the objects and need an interaction from the user, who would have to select all objects to be imported into the view. No usage afterwards for updating new/deleted objects (hosts/services). |
This pull request represents a first iteration for solving issue #295 .
Use Case
As a Business Process user, I want to easily add new child hosts/services to an existing business process covering two different scenarios:
Host1;Ping
,Host2;Ping
, ...Host<N>;Ping
Proposed Solution
As agreed with @lippserd, we added two new node types in the
AddNodeForm.php
:Host from filter
that allows the user to filter hosts with the help of a monitoring filterService from filter
that allows the user to filter services with the help of a monitoring filterOnce the user selects one of these two new node-type entries an input field called
Filter
and theNext
button will appear.The user will then insert the monitoring filter and press the button: the list of filtered host/services will populate the children multi-select. The
Next
button will then change into aRefresh
button that allows the user to change the monitoring filter and reload the list of the monitored objects, visible in the multi-select.