New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10929] Throw error if php5-curl is not installed #98

Closed
icinga-migration opened this Issue Jan 5, 2016 · 7 comments

Comments

Projects
None yet
1 participant
@icinga-migration
Copy link
Member

icinga-migration commented Jan 5, 2016

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10929

Created by bsheqa on 2016-01-05 11:05:03 +00:00

Assignee: tgelf
Status: Resolved (closed on 2016-03-06 20:15:04 +00:00)
Target Version: 1.0.0
Last Update: 2016-03-22 22:53:33 +00:00 (in Redmine)


The KickstartForm loads forever if php5-curl is not installed. It should throw an error and cancel the request.

Changesets

2016-03-06 20:12:59 +00:00 by tgelf 218e675

RestApiClient: fail without curl

fixes #10929

Relations:

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Jan 5, 2016

Updated by tgelf on 2016-01-05 12:17:10 +00:00

  • Status changed from New to Feedback
  • Assigned to set to bsheqa

Thanks for reporting this. Which PHP version are you using?

Cheers,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Jan 5, 2016

Updated by bsheqa on 2016-01-05 14:11:34 +00:00

PHP 5.5.9-1ubuntu4.14

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Mar 3, 2016

Updated by spillerm on 2016-03-03 10:08:04 +00:00

bobapple wrote:

The KickstartForm loads forever if php5-curl is not installed. It should throw an error and cancel the request.

+1 - was waiting for a while until I realized that my system was php5-curl missing ;-)

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Mar 3, 2016

Updated by mfriedrich on 2016-03-03 10:13:32 +00:00

  • Relates set to 11287
@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Mar 3, 2016

Updated by tgelf on 2016-03-03 10:51:52 +00:00

  • Status changed from Feedback to Assigned
  • Assigned to changed from bsheqa to tgelf

That's a pretty strange issue with specific PHP versions. Director has a fallback to a mode without curl for all PHP versions >= 5.4. This "version-limit" has been introduced as I experienced exactly this behaviour on RHEL6 with PHP 5.3.

So, 5.3 already throws exceptions without CURL - newer versions will fall back to "core" PHP methods. I guess I'll drop them completely and make CURL a hard requirement.

Thanks for reporting this,
Thomas

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Mar 6, 2016

Updated by tgelf on 2016-03-06 20:15:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 218e675.

@icinga-migration

This comment has been minimized.

Copy link
Member

icinga-migration commented Mar 22, 2016

Updated by tgelf on 2016-03-22 22:53:33 +00:00

  • Target Version set to 1.0.0

@icinga-migration icinga-migration added this to the 1.0.0 milestone Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment