Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvements for template details #241

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blindzero
Copy link

ping.ini icmp.ini hostalive.ini
Changed yUnitSystem from "none" to "msec" to be more accurate
disk.ini swap.ini
Changed legend from "Used" to "Free" as the default perfdata output of Icinga plugins delivered are based on this. Otherwise the graphs are "wrong way around". The screenshot of changed behaviour should explain it as a living example. If the filled area would be "Used" the state would be critical (nearly all Swap used), but it isn't as the filled area is still available.
Swap Graph

P.S.: This is my first other project pull request, so please be gentle ;)

@Al2Klimov
Copy link
Member

Hello @blindzero and thank you for contributing!

Have you also tested the disk graph?

Best,
AK

@blindzero
Copy link
Author

Hi @Al2Klimov
I think so ;)
image
You can see that the free is really free, compared to check output:
DISK OK - free space:C:\ 18460 MB (21%)
Best,
M.

templates/hostalive.ini Outdated Show resolved Hide resolved
templates/icmp.ini Outdated Show resolved Hide resolved
templates/ping.ini Outdated Show resolved Hide resolved
@blindzero blindzero force-pushed the feature/improve-template-details branch from d9a85e3 to 645f230 Compare October 9, 2020 21:22
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran check_disk and check_swap on the command line. Swap seems to actually yield free space, but disk yields the used space.

@bobapple Does msec vs sec matter depending on whether your Graphite data is in s or ms?

@nilmerg nilmerg added this to the v1.2.5 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants