Pad IPs before passing them to gmp_import()
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
previously approved these changes
Jul 24, 2023
yhabteab
force-pushed
the
fix-gmp-import
branch
from
8c94f5e
to
1e6eb87
Compare
lippserd
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gmp_import()expects the padded binary version of an IP address, but since we apply theIPbehavior on thetarget->ipwhen fetching from the database, it is transformed into a human-readable address and passed to thegmp_import()function as is. This causesJob::isAddrInside()to always returnfalsefor an IP and thus certificates are never rescanned.