Icinga\Protocol\File\FileReader::count(): call iterator_count() only …

…once per instance and cache the returned value
Icinga · Apr 24, 2015 · 3d53e6f · 3d53e6f
1 parent 5ba539b
commit 3d53e6f
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/library/Icinga/Protocol/File/FileReader.php b/library/Icinga/Protocol/File/FileReader.php
@@ -26,6 +26,13 @@ class FileReader implements Selectable, Countable
      */
     protected $filename;
 
+    /**
+     * Cache for static::count()
+     *
+     * @var int
+     */
+    protected $count = null;
+
     /**
      * Create a new reader
      *
@@ -71,7 +78,10 @@ public function select()
      */
     public function count()
     {
-        return iterator_count($this->iterate());
+        if ($this->count === null) {
+            $this->count = iterator_count($this->iterate());
+        }
+        return $this->count;
     }
 
     /**