Fix notes and action url in detail views

refs #5543
Icinga · Oct 1, 2015 · 9db4777 · 9db4777
1 parent f886172
commit 9db4777
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/modules/monitoring/application/views/scripts/show/components/actions.phtml b/modules/monitoring/application/views/scripts/show/components/actions.phtml
@@ -8,12 +8,17 @@ foreach ($navigation as $item) {
     $item->setObject($object);
 }
 
-// add warning to links that open in new tabs to improve accessibility, as recommended by WCAG20 G201
-$newTabInfo = sprintf('<span class="info-box display-on-hover"> %s </span>', $this->translate('opens in new window'));
+
 
 foreach ($object->getActionUrls() as $i => $link) {
     $navigation->addItem(
-        'Action ' . ($i + 1) . $newTabInfo,
+
+        // add warning to links that open in new tabs to improve accessibility, as recommended by WCAG20 G201
+        $this->icon(
+            'forward',
+            $this->translate('Link opens in new window'),
+            array('aria-label' => $this->translate('Link opens in new window'))
+        ) . ' Action ' . ($i + 1),
         array(
             'url'       => $link,
             'target'    => '_blank',

diff --git a/modules/monitoring/application/views/scripts/show/components/notes.phtml b/modules/monitoring/application/views/scripts/show/components/notes.phtml
@@ -15,15 +15,14 @@ if ($notes) {
 
 $links = $object->getNotesUrls();
 if (! empty($links)) {
-    // add warning to links that open in new tabs to improve accessibility, as recommended by WCAG20 G201
-    $newTabInfo = sprintf(
-        '<span class="info-box display-on-hover"> %s </span>',
-        $this->translate('opens in new window')
-    );
-
     foreach ($links as $link) {
         $navigation->addItem(
-            $this->escape($link) . $newTabInfo,
+            // add warning to links that open in new tabs to improve accessibility, as recommended by WCAG20 G201
+            $this->icon(
+                'forward',
+                $this->translate('Link opens in new window'),
+                array('aria-label' => $this->translate('Link opens in new window'))
+            ) . $this->escape($link),
             array(
                 'url'       => $link,
                 'target'    => '_blank',