Use the MenuItemRenderer render() implemnetations

refs #7658
Icinga · Apr 20, 2015 · 9ebf474 · 9ebf474
1 parent 4eb5f75
commit 9ebf474
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 35 deletions.
diff --git a/library/Icinga/Web/Menu/ForeignMenuItemRenderer.php b/library/Icinga/Web/Menu/ForeignMenuItemRenderer.php
@@ -9,15 +9,9 @@
 /**
  * A menu item with a link that surpasses the regular navigation link behavior
  */
-class ForeignMenuItemRenderer implements MenuItemRenderer {
-
-    public function render(Menu $menu)
-    {
-        return sprintf(
-            '<a href="%s" target="_self">%s%s<span></span></a>',
-            $menu->getUrl() ?: '#',
-            $menu->getIcon() ? '<img aria-hidden="true" src="' . Url::fromPath($menu->getIcon()) . '" class="icon" /> ' : '',
-            htmlspecialchars($menu->getTitle())
-        );
-    }
+class ForeignMenuItemRenderer extends MenuItemRenderer
+{
+    protected $attributes = array(
+        'target' => '_self'
+    );
 }
diff --git a/modules/monitoring/library/Monitoring/Web/Menu/MonitoringMenuItemRenderer.php b/modules/monitoring/library/Monitoring/Web/Menu/MonitoringMenuItemRenderer.php
@@ -6,10 +6,9 @@
 use Icinga\Web\Menu as Menu;
 use Icinga\Module\Monitoring\Backend\MonitoringBackend;
 use Icinga\Web\Menu\MenuItemRenderer;
-use Icinga\Web\Url;
-
-class MonitoringMenuItemRenderer implements MenuItemRenderer {
 
+class MonitoringMenuItemRenderer extends MenuItemRenderer
+{
     protected static $summary;
 
     protected $columns = array();
@@ -70,31 +69,18 @@ protected function countItems()
 
     public function render(Menu $menu)
     {
-        $count = $this->countItems();
-        $badge = '';
-        if ($count) {
-            $badge = sprintf(
+        return $this->getBadge() . $this->createLink($menu);
+    }
+
+    protected function getBadge()
+    {
+        if ($count = $this->countItems()) {
+            return sprintf(
                 '<div title="%s" class="badge-container"><span class="badge badge-critical">%s</span></div>',
                 $this->getBadgeTitle(),
                 $count
             );
         }
-        if ($menu->getIcon() && strpos($menu->getIcon(), '.') === false) {
-            return sprintf(
-                '%s <a href="%s"><i aria-hidden="true" class="icon-%s"></i>%s</a>',
-                $badge,
-                $menu->getUrl() ?: '#',
-                $menu->getIcon(),
-                htmlspecialchars($menu->getTitle())
-            );
-        }
-
-        return sprintf(
-            '%s<a href="%s">%s%s<span></span></a>',
-            $badge,
-            $menu->getUrl() ?: '#',
-            $menu->getIcon() ? '<img aria-hidden="true" src="' . Url::fromPath($menu->getIcon()) . '" class="icon" /> ' : '',
-            htmlspecialchars($menu->getTitle())
-        );
+        return '';
     }
 }