Fix that an object's notes and action url label is escaped twice

fixes #10218
Icinga · Sep 28, 2015 · d627f41 · d627f41
1 parent d4c1ca9
commit d627f41
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 3 deletions.
diff --git a/library/Icinga/Web/Navigation/Renderer/NavigationItemRenderer.php b/library/Icinga/Web/Navigation/Renderer/NavigationItemRenderer.php
@@ -36,6 +36,13 @@ class NavigationItemRenderer
      */
     protected $internalLinkTargets;
 
+    /**
+     * Whether to escape the label
+     *
+     * @var bool
+     */
+    protected $escapeLabel;
+
     /**
      * Create a new NavigationItemRenderer
      *
@@ -126,6 +133,29 @@ public function getItem()
         return $this->item;
     }
 
+    /**
+     * Set whether to escape the label
+     *
+     * @param   bool    $state
+     *
+     * @return  $this
+     */
+    public function setEscapeLabel($state = true)
+    {
+        $this->escapeLabel = (bool) $state;
+        return $this;
+    }
+
+    /**
+     * Return whether to escape the label
+     *
+     * @return  bool
+     */
+    public function getEscapeLabel()
+    {
+        return $this->escapeLabel !== null ? $this->escapeLabel : true;
+    }
+
     /**
      * Render the given navigation item as HTML anchor
      *
@@ -144,7 +174,9 @@ public function render(NavigationItem $item = null)
             );
         }
 
-        $label = $this->view()->escape($item->getLabel());
+        $label = $this->getEscapeLabel()
+            ? $this->view()->escape($item->getLabel())
+            : $item->getLabel();
         if (($icon = $item->getIcon()) !== null) {
             $label = $this->view()->icon($icon) . $label;
         }

diff --git a/modules/monitoring/application/views/scripts/show/components/actions.phtml b/modules/monitoring/application/views/scripts/show/components/actions.phtml
@@ -16,7 +16,11 @@ foreach ($object->getActionUrls() as $i => $link) {
         'Action ' . ($i + 1) . $newTabInfo,
         array(
             'url'       => $link,
-            'target'    => '_blank'
+            'target'    => '_blank',
+            'renderer'  => array(
+                'NavigationItemRenderer',
+                'escape_label' => false
+            )
         )
     );
 }

diff --git a/modules/monitoring/application/views/scripts/show/components/notes.phtml b/modules/monitoring/application/views/scripts/show/components/notes.phtml
@@ -26,7 +26,11 @@ if (! empty($links)) {
             $this->escape($link) . $newTabInfo,
             array(
                 'url'       => $link,
-                'target'    => '_blank'
+                'target'    => '_blank',
+                'renderer'  => array(
+                    'NavigationItemRenderer',
+                    'escape_label' => false
+                )
             )
         );
     }