[dev.icinga.com #10486] Menu rendering fails when no monitoring backend was configured

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10486

Created by mfrosch on 2015-10-29 11:30:21 +00:00

Assignee: aklimov
Status: Resolved (closed on 2016-04-25 13:30:03 +00:00)
Target Version: 2.3.2
Last Update: 2016-04-25 13:30:03 +00:00 (in Redmine)

---

Just noticed on a fresh installation, where no resources had been configured.

As soon as monitoring is enabled, the menu gets replaced by an Exception output...

Changesets

2016-04-25 13:26:08 +00:00 by aklimov eecd15e

NavigationItem: fall back to the default renderer if an error occurrs

fixes #10486

---

Relations:

• relates #10486
• duplicates #10486
• duplicates #10486
• duplicates #10486

[icinga-migration]

Updated by mfrosch on 2015-10-29 13:14:51 +00:00

Pushed a branch, please review.

[icinga-migration]

Updated by mfrosch on 2015-10-29 13:16:04 +00:00

Oh, you can't even configure a backend due to this error...

[icinga-migration]

Updated by mfrosch on 2015-10-29 13:21:02 +00:00

Pushed a commit that should fix the ConfigController...

[icinga-migration]

Updated by icinga-kanban on 2015-10-29 13:27:14 +00:00

Build !#1185 triggered by commit eeb6089 passed successfully.

Branch: origin/bugfix/robust-monitoring-menu-10486
Author: Markus Frosch

[icinga-migration]

Updated by jmeyer on 2015-12-15 12:43:12 +00:00

• Duplicated set to 10846

[icinga-migration]

Updated by jmeyer on 2015-12-15 12:43:24 +00:00

• Target Version set to Backlog

[icinga-migration]

Updated by tgelf on 2016-03-13 18:27:12 +00:00

• Relates set to 11276

[icinga-migration]

Updated by elippmann on 2016-03-16 10:43:33 +00:00

• Subject changed from menu rendering fails when monitoring backends are not configured to Menu rendering fails when no monitoring backend was configured
• Category changed from Monitoring to Framework
• Priority changed from Normal to High

[icinga-migration]

Updated by elippmann on 2016-03-16 10:43:44 +00:00

• Relates deleted 11276

[icinga-migration]

Updated by elippmann on 2016-03-16 10:43:52 +00:00

• Duplicated set to 11276

[icinga-migration]

Updated by elippmann on 2016-03-16 10:45:34 +00:00

• Relates set to 11392

[icinga-migration]

Updated by tgelf on 2016-03-16 11:12:49 +00:00

Please note that I do NOT consider this issue fixed unless the former rendering behaviour is restored: ANY exception in a custom menu item renderer MUST be caught, and the menu must silently fallback to the default renderer in that case. Catching errors in specific renderers is NOT considered a valid solution.

Just wanted to point this out as the more generic issue has been closed as a duplicate.

Thanks,
Thomas

[icinga-migration]

Updated by jmeyer on 2016-04-25 13:01:54 +00:00

• Status changed from New to Assigned
• Assigned to set to aklimov
• Target Version changed from Backlog to 2.3.2

[icinga-migration]

Updated by mfriedrich on 2016-04-25 13:06:13 +00:00

Oh. Seems I've opened a duplicate with #11649 then :)

[icinga-migration]

Updated by aklimov on 2016-04-25 13:30:03 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset eecd15e.

[icinga-migration]

Updated by elippmann on 2016-06-01 10:21:18 +00:00

• Duplicated set to 11649